Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): ButtonClose add new directive #5980

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Nov 16, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Visit the preview URL for this PR (updated for commit 1e50633):

https://taiga-ui--pr5980-button-close-dmz2erzx.web.app

(expires Sat, 25 Nov 2023 14:23:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Nov 16, 2023

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/main.(hash).js
373.98KB (+176B +0.05%) +10%
demo/browser/runtime.(hash).js
40.98KB (+47B +0.11%) +10%
demo/browser/vendor.(hash).js
198.19KB (+15B +0.01%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/polyfills.(hash).js
11.22KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change +238B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.27MB (+1.98KB +0.09%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebda2ed) 71.94% compared to head (1e50633) 71.94%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5980   +/-   ##
=======================================
  Coverage   71.94%   71.94%           
=======================================
  Files        1462     1462           
  Lines       15974    15974           
  Branches     2268     2268           
=======================================
  Hits        11493    11493           
  Misses       4110     4110           
  Partials      371      371           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.62% <ø> (ø)
addon-mobile 60.61% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 78.00% <ø> (ø)
kit 70.18% <ø> (ø)
summary 71.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladimirpotekhin vladimirpotekhin marked this pull request as draft November 16, 2023 14:45
@vladimirpotekhin vladimirpotekhin marked this pull request as ready for review November 21, 2023 16:01
@vladimirpotekhin
Copy link
Member Author

@nsbarsukov @waterplea rewritten to just a directive for customizing tuiButton, take a look plz

@vladimirpotekhin vladimirpotekhin force-pushed the button-close branch 2 times, most recently from f1ddeea to 557a5fc Compare November 24, 2023 11:02
@waterplea waterplea merged commit 8c79059 into main Nov 24, 2023
34 checks passed
@waterplea waterplea deleted the button-close branch November 24, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants