Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-doc): add tuiSortPages #5817

Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat(addon-doc): add tuiSortPages #5817

merged 1 commit into from
Nov 2, 2023

Conversation

MillerSvt
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

The menu items in the documentation didn't sorted

Closes #5815

What is the new behaviour?

The menu items in the documentation sorted alphabetically

Copy link

lumberjack-bot bot commented Nov 1, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Nov 1, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
341.05KB (+259B +0.07%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.91KB +10%
demo/browser/runtime.(hash).js
39.48KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +250B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (+40B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #5817 (21907d1) into main (1154826) will decrease coverage by 0.07%.
Report is 9 commits behind head on main.
The diff coverage is 22.72%.

@@            Coverage Diff             @@
##             main    #5817      +/-   ##
==========================================
- Coverage   71.99%   71.92%   -0.07%     
==========================================
  Files        1460     1462       +2     
  Lines       15941    15963      +22     
  Branches     2254     2261       +7     
==========================================
+ Hits        11477    11482       +5     
- Misses       4097     4111      +14     
- Partials      367      370       +3     
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.66% <22.72%> (-0.87%) ⬇️
addon-mobile 60.80% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 77.96% <ø> (ø)
kit 70.11% <ø> (ø)
summary 71.92% <22.72%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
projects/addon-doc/utils/index.ts 100.00% <100.00%> (ø)
projects/addon-doc/utils/is-page-group.ts 50.00% <50.00%> (ø)
projects/addon-doc/utils/sort-pages.ts 11.11% <11.11%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MillerSvt
Copy link
Collaborator Author

I think we shouldn't sort 'Foundations' and 'Documentation' sections. I will exclude this sections from sorting.

@splincode splincode changed the title feat(demo): sort the menu items in the documentation chore(demo): sort the menu items in the documentation Nov 1, 2023
@MillerSvt MillerSvt requested a review from splincode November 1, 2023 13:39
@MillerSvt MillerSvt requested a review from splincode November 1, 2023 14:28
@MillerSvt MillerSvt requested a review from splincode November 2, 2023 09:06
@splincode splincode changed the title chore(demo): sort the menu items in the documentation feat(addon-doc): add tuiSortPages Nov 2, 2023
@splincode splincode merged commit 00f10e8 into taiga-family:main Nov 2, 2023
31 checks passed
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - Sort the menu items in the documentation
3 participants