Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): add TuiCard #5777

Merged
merged 1 commit into from
Nov 13, 2023
Merged

feat(experimental): add TuiCard #5777

merged 1 commit into from
Nov 13, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Oct 27, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the new behaviour?

image image image image image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 27, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 27, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
40.2KB (+376B +0.92%) +10%
demo/browser/main.(hash).js
340.46KB (+57B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.77KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +433B +0.07%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.26MB (+11.83KB +0.51%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/feat/card branch from 59df2c8 to 7c0c490 Compare October 27, 2023 13:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Visit the preview URL for this PR (updated for commit 9fb1994):

https://taiga-ui--pr5777-splincode-feat-card-dgcyrexh.web.app

(expires Tue, 14 Nov 2023 10:58:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #5777 (f19175a) into main (615e829) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f19175a differs from pull request most recent head 9fb1994. Consider uploading reports for the commit 9fb1994 to get more accurate results

@@            Coverage Diff             @@
##             main    #5777      +/-   ##
==========================================
+ Coverage   71.90%   71.93%   +0.02%     
==========================================
  Files        1462      806     -656     
  Lines       15971     9819    -6152     
  Branches     2263     1486     -777     
==========================================
- Hits        11484     7063    -4421     
+ Misses       4115     2503    -1612     
+ Partials      372      253     -119     
Flag Coverage Δ
addon-charts 54.91% <ø> (-16.19%) ⬇️
addon-doc ?
addon-mobile ?
addon-table ?
addon-tablebars ?
cdk ?
core 77.99% <ø> (ø)
kit 70.08% <ø> (ø)
summary 71.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 656 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@splincode splincode force-pushed the splincode/feat/card branch 3 times, most recently from ddf0e90 to 941f9a4 Compare October 27, 2023 15:05
projects/demo/src/modules/app/pages.ts Outdated Show resolved Hide resolved
projects/demo/src/modules/app/app.routes.ts Outdated Show resolved Hide resolved
projects/experimental/components/card/card.component.ts Outdated Show resolved Hide resolved
projects/experimental/components/card/card.style.less Outdated Show resolved Hide resolved
projects/experimental/components/card/card.style.less Outdated Show resolved Hide resolved
projects/experimental/components/card/card.style.less Outdated Show resolved Hide resolved
@splincode splincode force-pushed the splincode/feat/card branch 3 times, most recently from f43102c to 780b8da Compare October 30, 2023 10:12
@splincode splincode requested a review from waterplea October 30, 2023 10:12
@splincode splincode force-pushed the splincode/feat/card branch from 780b8da to b8a7ca9 Compare October 30, 2023 10:26
@splincode splincode force-pushed the splincode/feat/card branch from b8a7ca9 to 55896ea Compare November 7, 2023 10:15
@splincode splincode force-pushed the splincode/feat/card branch 2 times, most recently from 29f8a2c to f03696d Compare November 7, 2023 13:44
@splincode splincode requested a review from waterplea November 7, 2023 13:45
@splincode splincode force-pushed the splincode/feat/card branch 3 times, most recently from 2cb2ecd to 8122dc7 Compare November 8, 2023 19:55
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few cosmetic comments, otherwise LGTM 👍

@splincode splincode force-pushed the splincode/feat/card branch from 8122dc7 to f652be8 Compare November 9, 2023 17:30
@splincode splincode merged commit d2c5e86 into main Nov 13, 2023
32 checks passed
@splincode splincode deleted the splincode/feat/card branch November 13, 2023 11:59
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 19, 2023
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants