Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - Change status-bar color when opening dialog #5685

Closed
zergunteg opened this issue Oct 19, 2023 · 2 comments · Fixed by #8240
Closed

🚀 - Change status-bar color when opening dialog #5685

zergunteg opened this issue Oct 19, 2023 · 2 comments · Fixed by #8240
Labels
P3 This issue has low priority

Comments

@zergunteg
Copy link

zergunteg commented Oct 19, 2023

Description

When dialog and sheetDialog are used in PWA applications, there is an issue that the status bar remains the same color as the main background of the application. It would be better to dynamically change the color of the status bar when the dialog is opened.

document.querySelector('meta[name="theme-color"]')?.setAttribute('content', content)

i suggest using а #404040 or #333 color

@github-project-automation github-project-automation bot moved this to 💡 Backlog in Taiga-family Oct 19, 2023
@zergunteg zergunteg changed the title 🚀 - 🚀 - Change status-bar color when opening dialog Oct 19, 2023
@waterplea waterplea added P3 This issue has low priority and removed state: need triage labels Oct 20, 2023
@splincode
Copy link
Member

@waterplea Is it should be a tui service for dynamic changes meta color?

service = inject(TuiMetaColorService);

// ...

service.setColor('red');

@waterplea
Copy link
Collaborator

@waterplea Is it should be a tui service for dynamic changes meta color?

service = inject(TuiMetaColorService);

// ...

service.setColor('red');

Sounds good. It should also allow getting it so that dialogs can restore it after they are closed. Also we need to think if it should be always on, maybe some apps have it configured to some color that works well with open dialogs 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 This issue has low priority
Development

Successfully merging a pull request may close this issue.

3 participants