Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputPhone fix initial value #5438

Merged
merged 1 commit into from
Sep 21, 2023
Merged

fix(kit): InputPhone fix initial value #5438

merged 1 commit into from
Sep 21, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #5415

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 20, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Sep 20, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
332.27KB +10%
demo/browser/vendor.(hash).js
200.86KB +10%
demo/browser/runtime.(hash).js
37.48KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +4B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.14MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Visit the preview URL for this PR (updated for commit 4e50b21):

https://taiga-ui--pr5438-phone-cd-84lrqqnh.web.app

(expires Thu, 21 Sep 2023 15:40:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #5438 (4e50b21) into main (c8e0558) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5438   +/-   ##
=======================================
  Coverage   72.70%   72.70%           
=======================================
  Files        1438     1438           
  Lines       15634    15635    +1     
  Branches     2186     2186           
=======================================
+ Hits        11367    11368    +1     
  Misses       3911     3911           
  Partials      356      356           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.38% <ø> (ø)
addon-mobile 61.32% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 80.13% <ø> (ø)
core 78.58% <ø> (ø)
kit 70.96% <100.00%> (+<0.01%) ⬆️
summary 72.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...it/components/input-phone/input-phone.component.ts 81.48% <100.00%> (+0.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit 5b240b8 into main Sep 21, 2023
@splincode splincode deleted the phone-cd branch September 21, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - tui-input-phone value is not displayed under certain circumstances
3 participants