Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): replace whole icon name instead of substring #5334

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #5322

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 9, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Sep 9, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
331.34KB +10%
demo/browser/vendor.(hash).js
200.83KB +10%
demo/browser/runtime.(hash).js
36.78KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.11MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2023

Visit the preview URL for this PR (updated for commit 3d83e02):

https://taiga-ui--pr5334-splincode-fix-issues-trw6i669.web.app

(expires Sun, 10 Sep 2023 17:17:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #5334 (3d83e02) into main (273f6c1) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5334   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files        1436     1436           
  Lines       15603    15603           
  Branches     2191     2191           
=======================================
  Hits        11280    11280           
  Misses       3963     3963           
  Partials      360      360           
Flag Coverage Δ
addon-charts 71.16% <ø> (ø)
addon-doc 60.43% <ø> (ø)
addon-mobile 61.32% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 79.90% <ø> (ø)
core 76.89% <ø> (ø)
kit 70.92% <ø> (ø)
summary 72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit cdc0802 into main Sep 11, 2023
@splincode splincode deleted the splincode/fix/issues/5322 branch September 11, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - wrong icons migration
3 participants