Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support appearance in dialog #5280

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Sep 4, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #5243

What is the new behavior?

image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 4, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Sep 4, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
36.73KB (+49B +0.13%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
331.39KB +10%
demo/browser/vendor.(hash).js
200.83KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +55B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.11MB (+1.67KB +0.08%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Visit the preview URL for this PR (updated for commit 7e9ca9d):

https://taiga-ui--pr5280-splincode-feat-appea-6eohmtn6.web.app

(expires Wed, 06 Sep 2023 13:19:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #5280 (4de0e75) into main (c78185d) will not change coverage.
Report is 9 commits behind head on main.
The diff coverage is n/a.

❗ Current head 4de0e75 differs from pull request most recent head 7e9ca9d. Consider uploading reports for the commit 7e9ca9d to get more accurate results

@@           Coverage Diff           @@
##             main    #5280   +/-   ##
=======================================
  Coverage   72.28%   72.28%           
=======================================
  Files        1436     1436           
  Lines       15604    15604           
  Branches     2190     2190           
=======================================
  Hits        11280    11280           
  Misses       3964     3964           
  Partials      360      360           
Flag Coverage Δ
addon-charts 71.16% <ø> (ø)
addon-doc 60.43% <ø> (ø)
addon-mobile 61.28% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 79.92% <ø> (ø)
core 76.89% <ø> (ø)
kit 70.92% <ø> (ø)
summary 72.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rojects/core/components/dialog/dialog.component.ts 77.41% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode force-pushed the splincode/feat/appearance-dialog branch 3 times, most recently from 3ae5fb1 to 160278c Compare September 4, 2023 09:47
@splincode splincode force-pushed the splincode/feat/appearance-dialog branch from 160278c to 9a9c195 Compare September 4, 2023 09:52
@splincode splincode force-pushed the splincode/feat/appearance-dialog branch from 8c9b5c9 to 4de0e75 Compare September 4, 2023 13:05
@splincode splincode force-pushed the splincode/feat/appearance-dialog branch from 0a9c559 to 7e9ca9d Compare September 5, 2023 13:10
@splincode splincode merged commit 126d3dd into main Sep 5, 2023
@splincode splincode deleted the splincode/feat/appearance-dialog branch September 5, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Add configuration for dialog position
3 participants