Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): drawing correctly the loader #5213

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4773

What is the new behavior?

image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 28, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Aug 28, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
331.23KB (+39B +0.01%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.63KB +10%
demo/browser/runtime.(hash).js
36.54KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +34B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.1MB (+63B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

Visit the preview URL for this PR (updated for commit 79a82a0):

https://taiga-ui--pr5213-splincode-fix-issues-x9h03uuh.web.app

(expires Wed, 30 Aug 2023 09:47:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #5213 (79a82a0) into main (b789cd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5213   +/-   ##
=======================================
  Coverage   72.28%   72.28%           
=======================================
  Files        1436     1436           
  Lines       15597    15597           
  Branches     2189     2189           
=======================================
  Hits        11274    11274           
  Misses       3963     3963           
  Partials      360      360           
Flag Coverage Δ
addon-charts 71.16% <ø> (ø)
addon-doc 60.43% <ø> (ø)
addon-mobile 61.28% <ø> (ø)
addon-table 61.01% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 79.91% <ø> (ø)
core 76.89% <ø> (ø)
kit 70.92% <ø> (ø)
summary 72.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vladimirpotekhin
Copy link
Member

Thickness changed in xs/xl sizes. Is this expected?

Снимок экрана 2023-08-28 в 14 19 53 Снимок экрана 2023-08-28 в 14 20 02

@splincode splincode force-pushed the splincode/fix/issues/4773 branch 5 times, most recently from 6265664 to c7ee0b8 Compare August 29, 2023 08:46
@splincode splincode force-pushed the splincode/fix/issues/4773 branch from c7ee0b8 to 79a82a0 Compare August 29, 2023 09:42
@splincode
Copy link
Member Author

@nsbarsukov hello, please review me

@splincode splincode merged commit 71de5aa into main Sep 1, 2023
@splincode splincode deleted the splincode/fix/issues/4773 branch September 1, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Loader in Safari doesn't work as expected
4 participants