Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Hint fix positioning near the right edge of the viewport #5001

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4994

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 28, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

Visit the preview URL for this PR (updated for commit cf6bc71):

https://taiga-ui--pr5001-hint-7r3jlf9a.web.app

(expires Sat, 29 Jul 2023 16:45:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.01% ⚠️

Comparison is base (39d1b62) 72.19% compared to head (cf6bc71) 72.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5001      +/-   ##
==========================================
- Coverage   72.19%   72.19%   -0.01%     
==========================================
  Files        1415     1415              
  Lines       15327    15330       +3     
  Branches     2127     2127              
==========================================
+ Hits        11066    11068       +2     
- Misses       3915     3916       +1     
  Partials      346      346              
Flag Coverage Δ
addon-charts 70.82% <ø> (ø)
addon-doc 59.50% <ø> (ø)
addon-mobile 61.21% <ø> (ø)
addon-table 60.35% <ø> (ø)
addon-tablebars 92.72% <ø> (ø)
cdk 79.60% <ø> (ø)
core 76.89% <60.00%> (-0.01%) ⬇️
kit 71.18% <ø> (ø)
summary 72.19% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
projects/core/directives/hint/hint.component.ts 64.58% <60.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bundlemon
Copy link

bundlemon bot commented Jul 28, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
324.28KB (+1.7KB +0.53%) +10%
demo/browser/runtime.(hash).js
36.06KB (+169B +0.46%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.62KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +1.86KB +0.31%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.07MB (+9.64KB +0.46%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin merged commit 6fcb214 into main Jul 31, 2023
@vladimirpotekhin vladimirpotekhin deleted the hint branch July 31, 2023 06:38
@well-done-bot
Copy link

well-done-bot bot commented Jul 31, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Tooltip for mobile devices breaks at a certain width
3 participants