Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pinned i18n dependency #4970

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix(core): pinned i18n dependency #4970

merged 1 commit into from
Jul 25, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Jul 24, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4969

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 24, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 0203997):

https://taiga-ui--pr4970-splincode-ci-fix-mqug6065.web.app

(expires Tue, 25 Jul 2023 07:50:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Jul 24, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
322.66KB +10%
demo/browser/vendor.(hash).js
200.43KB +10%
demo/browser/runtime.(hash).js
35.82KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
1.98MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (89945b8) 72.25% compared to head (0203997) 72.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4970   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files        1407     1407           
  Lines       15238    15238           
  Branches     2120     2120           
=======================================
  Hits        11010    11010           
  Misses       3883     3883           
  Partials      345      345           
Flag Coverage Δ
addon-charts 70.80% <ø> (ø)
addon-doc 59.50% <ø> (ø)
addon-mobile 61.21% <ø> (ø)
addon-table 60.35% <ø> (ø)
addon-tablebars 92.72% <ø> (ø)
cdk 79.76% <ø> (ø)
core 76.86% <ø> (ø)
kit 71.18% <ø> (ø)
summary 72.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode requested a review from nsbarsukov July 24, 2023 09:57
@splincode
Copy link
Member Author

@nsbarsukov @vladimirpotekhin hello, please review me :)

@waterplea waterplea merged commit 001ccdd into main Jul 25, 2023
@waterplea waterplea deleted the splincode/ci/fix branch July 25, 2023 08:53
@well-done-bot
Copy link

well-done-bot bot commented Jul 25, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - can not install 3.36.2 version
3 participants