Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Dropdown add appearance option #4795

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4393

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 28, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jun 28, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
38.17KB (+42B +0.11%) +10%
demo/browser/main.(hash).js
323.52KB (+31B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.31KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +73B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.26MB (+1.1KB +0.05%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023

Visit the preview URL for this PR (updated for commit 52c711e):

https://taiga-ui--pr4795-dropdown-appearance-5pd4nqs1.web.app

(expires Fri, 30 Jun 2023 05:12:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 60.00% and project coverage change: -4.05 ⚠️

Comparison is base (c8df8d8) 69.63% compared to head (52c711e) 65.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4795      +/-   ##
==========================================
- Coverage   69.63%   65.58%   -4.05%     
==========================================
  Files        1575      846     -729     
  Lines       17268     8369    -8899     
  Branches     2410     1069    -1341     
==========================================
- Hits        12024     5489    -6535     
+ Misses       4844     2713    -2131     
+ Partials      400      167     -233     
Flag Coverage Δ
addon-charts 71.73% <ø> (ø)
addon-doc 59.69% <ø> (ø)
addon-editor 49.05% <ø> (ø)
addon-mobile 61.25% <60.00%> (-0.09%) ⬇️
addon-table 60.85% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 79.87% <ø> (ø)
core ?
kit ?
summary 65.58% <60.00%> (-4.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et/directives/sheet-close/sheet-close.directive.ts 41.66% <60.00%> (-1.20%) ⬇️

... and 729 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 0bb3d0c into main Jun 29, 2023
@splincode splincode deleted the dropdown-appearance branch June 29, 2023 07:38
@well-done-bot
Copy link

well-done-bot bot commented Jun 29, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Dropdown - allow customization
3 participants