feat(kit): InputNumber uses Maskito instead of legacy text-mask
#4725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (2)
Unchanged files (4)
Total files change -492B -0.08% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
Visit the preview URL for this PR (updated for commit 6d04bff): https://taiga-ui--pr4725-maskito-input-number-u5bl15nj.web.app (expires Tue, 27 Jun 2023 11:15:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
nsbarsukov
force-pushed
the
maskito-input-number
branch
from
325724f to
01fb918
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4725 +/- ##
==========================================
- Coverage 69.88% 69.70% -0.19%
==========================================
Files 1574 1574
Lines 17323 17302 -21
Branches 2431 2419 -12
==========================================
- Hits 12106 12060 -46
- Misses 4822 4844 +22
- Partials 395 398 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
nsbarsukov
force-pushed
the
maskito-input-number
branch
2 times, most recently
from
0a60621 to
71a9e6e
Compare
nsbarsukov
commented
Jun 23, 2023
projects/kit/components/input-slider/test/input-slider.component.spec.ts
Show resolved
Hide resolved
nsbarsukov
force-pushed
the
maskito-input-number
branch
2 times, most recently
from
b8cbc7e to
49ad1d8
Compare
nsbarsukov
force-pushed
the
maskito-input-number
branch
from
49ad1d8 to
22c1ba9
Compare
nsbarsukov
changed the title
InputNumber uses Maskito instead of legacy text-maskInputNumber uses Maskito instead of legacy text-mask
nsbarsukov
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
splincode
as code owners
vladimirpotekhin
approved these changes
Jun 27, 2023
splincode
approved these changes
Jun 27, 2023
|
|
waterplea
reviewed
Jun 27, 2023
| @@ -146,15 +144,11 @@ export class TuiInputNumberComponent | |||
| } | |||
|
|
|||
| get formattedValue(): string { | |||
| return this.getFormattedValue(this.value || 0); | |||
| return this.value !== null ? this.getFormattedValue(this.value || 0) : ''; | |||
There was a problem hiding this comment.
It is required for NaN.
See https://taiga-ui.dev/charts/arc-chart#sizes (it displays NaN as zero).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Closes #4540
Closes #3664
Closes #4341
Closes #120