Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-editor): support translate/spellcheck option in editor DI #4688

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4687

image

What is the new behavior?

image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 16, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jun 16, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
326.35KB +10%
demo/browser/vendor.(hash).js
200.28KB +10%
demo/browser/runtime.(hash).js
37.97KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.25MB (+332B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

Visit the preview URL for this PR (updated for commit 02a58f2):

https://taiga-ui--pr4688-splincode-feat-issue-d96bhyr4.web.app

(expires Sat, 17 Jun 2023 13:17:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: -0.02 ⚠️

Comparison is base (c29e0e8) 69.97% compared to head (02a58f2) 69.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4688      +/-   ##
==========================================
- Coverage   69.97%   69.96%   -0.02%     
==========================================
  Files        1574     1574              
  Lines       17275    17281       +6     
  Branches     2418     2420       +2     
==========================================
+ Hits        12089    12090       +1     
- Misses       4795     4800       +5     
  Partials      391      391              
Flag Coverage Δ
addon-charts 71.61% <ø> (ø)
addon-doc 59.74% <ø> (ø)
addon-editor 49.16% <28.57%> (-0.10%) ⬇️
addon-mobile 61.31% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 80.82% <ø> (ø)
core 77.06% <ø> (ø)
kit 71.85% <ø> (ø)
summary 69.96% <28.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/addon-editor/tokens/editor-options.ts 71.42% <ø> (ø)
...addon-editor/components/editor/editor.component.ts 22.72% <16.66%> (-0.61%) ⬇️
...ts/addon-editor/components/editor/editor.module.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/feat/issues/4687 branch from b27b9af to 28c1a56 Compare June 16, 2023 13:07
@splincode splincode force-pushed the splincode/feat/issues/4687 branch from 28c1a56 to 02a58f2 Compare June 16, 2023 13:08
@splincode splincode merged commit 98df5c5 into main Jun 19, 2023
@splincode splincode deleted the splincode/feat/issues/4687 branch June 19, 2023 08:05
@well-done-bot
Copy link

well-done-bot bot commented Jun 19, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - addon-editor add flag to enable spellcheck
3 participants