Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputDateRange freezes UI if [minLength]/[maxLength] are ommited #4671

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

nsbarsukov
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4642

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 15, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Jun 15, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
326.1KB +10%
demo/browser/vendor.(hash).js
200.28KB +10%
demo/browser/runtime.(hash).js
37.98KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.25MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 63bac16):

https://taiga-ui--pr4671-input-date-range-fix-123swz6q.web.app

(expires Fri, 16 Jun 2023 06:12:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (85fa980) 69.93% compared to head (63bac16) 69.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4671      +/-   ##
==========================================
+ Coverage   69.93%   69.99%   +0.05%     
==========================================
  Files        1574     1574              
  Lines       17252    17252              
  Branches     2416     2416              
==========================================
+ Hits        12065    12075      +10     
+ Misses       4796     4787       -9     
+ Partials      391      390       -1     
Flag Coverage Δ
addon-charts 71.61% <ø> (ø)
addon-doc 59.80% <ø> (ø)
addon-editor 49.23% <ø> (ø)
addon-mobile 61.31% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 80.92% <ø> (ø)
core 77.06% <ø> (ø)
kit 71.87% <100.00%> (+0.17%) ⬆️
summary 69.99% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/input-date-range/input-date-range.component.ts 77.77% <100.00%> (+2.77%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nsbarsukov nsbarsukov merged commit c41d568 into main Jun 15, 2023
@nsbarsukov nsbarsukov deleted the input-date-range-fix branch June 15, 2023 07:32
@well-done-bot
Copy link

well-done-bot bot commented Jun 15, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🤖 - Unit tests for InputDateRange fail with CPU 100%
3 participants