Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-charts): BarChart fix hover effect #4547

Merged
merged 1 commit into from
May 29, 2023
Merged

fix(addon-charts): BarChart fix hover effect #4547

merged 1 commit into from
May 29, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #4545

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 29, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented May 29, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
325.91KB +10%
demo/browser/vendor.(hash).js
198.99KB +10%
demo/browser/runtime.(hash).js
37.88KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.24MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 1bc60d2):

https://taiga-ui--pr4547-chart-qytqku6t.web.app

(expires Tue, 30 May 2023 13:15:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b1d627d) 70.08% compared to head (1bc60d2) 70.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4547   +/-   ##
=======================================
  Coverage   70.08%   70.08%           
=======================================
  Files        1569     1569           
  Lines       17194    17194           
  Branches     2417     2417           
=======================================
  Hits        12050    12050           
  Misses       4750     4750           
  Partials      394      394           
Flag Coverage Δ
addon-charts 71.41% <ø> (ø)
addon-doc 59.80% <ø> (ø)
addon-editor 49.75% <ø> (ø)
addon-mobile 62.13% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.42% <ø> (ø)
core 76.80% <ø> (ø)
kit 71.71% <ø> (ø)
summary 70.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...charts/components/bar-chart/bar-chart.component.ts 92.59% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea waterplea merged commit a03aa4f into main May 29, 2023
@waterplea waterplea deleted the chart branch May 29, 2023 15:51
@well-done-bot
Copy link

well-done-bot bot commented May 29, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - BarChart when hovering over the bar the next element also becomes highlighted
3 participants