Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): TextArea enable icons #4512

Merged
merged 2 commits into from
May 22, 2023
Merged

feat(kit): TextArea enable icons #4512

merged 2 commits into from
May 22, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #3838
Closes #3485

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 22, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented May 22, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
325.43KB (+343B +0.1%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
197.88KB +10%
demo/browser/runtime.(hash).js
37.84KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +342B +0.06%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (+509B +0.02%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

Visit the preview URL for this PR (updated for commit 1296bff):

https://taiga-ui--pr4512-textarea-gjoqsox0.web.app

(expires Tue, 23 May 2023 10:17:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.60 ⚠️

Comparison is base (4488eab) 70.86% compared to head (1296bff) 70.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4512      +/-   ##
==========================================
- Coverage   70.86%   70.27%   -0.60%     
==========================================
  Files        1486     1570      +84     
  Lines       16232    17163     +931     
  Branches     2325     2413      +88     
==========================================
+ Hits        11503    12061     +558     
- Misses       4348     4706     +358     
- Partials      381      396      +15     
Flag Coverage Δ
addon-charts 71.41% <ø> (ø)
addon-doc 59.80% <ø> (?)
addon-editor 49.75% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.42% <ø> (ø)
core 76.87% <ø> (ø)
kit 72.15% <85.71%> (+0.01%) ⬆️
summary 70.27% <85.71%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/kit/components/text-area/text-area.component.ts 79.62% <85.71%> (+1.19%) ⬆️

... and 84 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nsbarsukov nsbarsukov merged commit c6f6a7e into main May 22, 2023
@nsbarsukov nsbarsukov deleted the textarea branch May 22, 2023 12:47
@well-done-bot
Copy link

well-done-bot bot commented May 22, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - tuiTextfieldIcons doesn't work on Textarea 🚀 - Support tuiTextfieldCustomContent in textarea
3 participants