Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputTag fix vertical jumps on multi line size="m" and label inside #4506

Merged
merged 1 commit into from
May 22, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 20, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@waterplea waterplea changed the title fix(kit): InputTag fix vertical jumps on multi line size="m" and label outside fix(kit): InputTag fix vertical jumps on multi line size="m" and label inside May 20, 2023
@bundlemon
Copy link

bundlemon bot commented May 20, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
324.99KB +10%
demo/browser/vendor.(hash).js
197.88KB +10%
demo/browser/runtime.(hash).js
37.83KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +4B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.23MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2023

Visit the preview URL for this PR (updated for commit 1bcdd7a):

https://taiga-ui--pr4506-input-tag-6y447t1c.web.app

(expires Sun, 21 May 2023 09:47:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aafa41b) 70.27% compared to head (1bcdd7a) 70.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4506   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files        1570     1570           
  Lines       17157    17157           
  Branches     2412     2412           
=======================================
  Hits        12057    12057           
  Misses       4704     4704           
  Partials      396      396           
Flag Coverage Δ
addon-charts 71.41% <ø> (ø)
addon-doc 59.80% <ø> (ø)
addon-editor 49.75% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.42% <ø> (ø)
core 76.87% <ø> (ø)
kit 72.16% <ø> (ø)
summary 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin merged commit b1a9a65 into main May 22, 2023
@vladimirpotekhin vladimirpotekhin deleted the input-tag branch May 22, 2023 07:49
@well-done-bot
Copy link

well-done-bot bot commented May 22, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants