-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Textfield
allow showing hints for disabled control
#4500
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +75B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 1dfb5b4): https://taiga-ui--pr4500-hint-vtoomh0r.web.app (expires Sat, 20 May 2023 09:37:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4500 +/- ##
==========================================
- Coverage 70.29% 70.27% -0.02%
==========================================
Files 1569 1570 +1
Lines 17146 17157 +11
Branches 2409 2412 +3
==========================================
+ Hits 12052 12057 +5
- Misses 4701 4704 +3
- Partials 393 396 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hint on disabled input is not accessible from keyboard, this is ok?
I guess. Let's keep it this way for the time being. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?