Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Textfield allow showing hints for disabled control #4500

Merged
merged 1 commit into from
May 19, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 19, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented May 19, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
324.99KB (+75B +0.02%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
197.88KB +10%
demo/browser/runtime.(hash).js
37.83KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +75B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.23MB (+97B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 1dfb5b4):

https://taiga-ui--pr4500-hint-vtoomh0r.web.app

(expires Sat, 20 May 2023 09:37:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.02 ⚠️

Comparison is base (1b5653f) 70.29% compared to head (1dfb5b4) 70.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4500      +/-   ##
==========================================
- Coverage   70.29%   70.27%   -0.02%     
==========================================
  Files        1569     1570       +1     
  Lines       17146    17157      +11     
  Branches     2409     2412       +3     
==========================================
+ Hits        12052    12057       +5     
- Misses       4701     4704       +3     
- Partials      393      396       +3     
Flag Coverage Δ
addon-charts 71.41% <ø> (ø)
addon-doc 59.80% <ø> (ø)
addon-editor 49.75% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.42% <100.00%> (ø)
core 76.87% <50.00%> (-0.02%) ⬇️
kit 72.16% <75.00%> (-0.05%) ⬇️
summary 70.27% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rectives/textfield-controller/textfield-options.ts 100.00% <ø> (ø)
...imitive-textfield/primitive-textfield.component.ts 76.19% <50.00%> (-0.64%) ⬇️
...ts/kit/components/text-area/text-area.component.ts 78.43% <50.00%> (-1.17%) ⬇️
projects/cdk/utils/focus/get-native-focused.ts 85.71% <100.00%> (ø)
...ts/kit/components/input-tag/input-tag.component.ts 77.84% <100.00%> (+0.26%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@vladimirpotekhin vladimirpotekhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hint on disabled input is not accessible from keyboard, this is ok?

@waterplea
Copy link
Collaborator Author

hint on disabled input is not accessible from keyboard, this is ok?

I guess. Let's keep it this way for the time being.

@waterplea waterplea merged commit c1f73d1 into main May 19, 2023
@waterplea waterplea deleted the hint branch May 19, 2023 14:02
@well-done-bot
Copy link

well-done-bot bot commented May 19, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants