Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): Files add expanded input-output #4479

Merged
merged 1 commit into from
May 17, 2023
Merged

feat(kit): Files add expanded input-output #4479

merged 1 commit into from
May 17, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #4468

What is the new behavior?

new input [(expanded)]

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 17, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented May 17, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
324.64KB (+36B +0.01%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
197.37KB +10%
demo/browser/runtime.(hash).js
37.82KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +34B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.23MB (+221B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit c409697):

https://taiga-ui--pr4479-files-dosg8tnd.web.app

(expires Thu, 18 May 2023 10:13:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (481c805) 69.83% compared to head (c409697) 69.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4479      +/-   ##
==========================================
- Coverage   69.83%   69.82%   -0.01%     
==========================================
  Files        1560     1560              
  Lines       17101    17103       +2     
  Branches     2406     2406              
==========================================
  Hits        11943    11943              
- Misses       4763     4765       +2     
  Partials      395      395              
Flag Coverage Δ
addon-charts 71.41% <ø> (ø)
addon-doc 51.72% <ø> (ø)
addon-editor 49.85% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.42% <ø> (ø)
core 76.89% <ø> (ø)
kit 72.10% <0.00%> (-0.03%) ⬇️
summary 69.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/files/files.component.ts 35.71% <0.00%> (-5.96%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit 90d8efe into main May 17, 2023
@splincode splincode deleted the files branch May 17, 2023 13:08
@well-done-bot
Copy link

well-done-bot bot commented May 17, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - tui-files toggle/hidden not working
3 participants