-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(addon-editor): focus should trigger only for outside contenteditable area #4471
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 8351946): https://taiga-ui--pr4471-splincode-fix-editor-v0sdd1h6.web.app (expires Thu, 18 May 2023 10:30:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4471 +/- ##
==========================================
- Coverage 69.83% 69.82% -0.02%
==========================================
Files 1560 1560
Lines 17101 17105 +4
Branches 2406 2408 +2
==========================================
Hits 11943 11943
- Misses 4763 4767 +4
Partials 395 395
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
It should be like in textfields, only prevent and focus if clicked outside of actual focusable part: |
93931f2
to
7b9e8e6
Compare
@waterplea fixed |
click
instead of mousedown.prevent
7b9e8e6
to
8351946
Compare
PR Type
What kind of change does this PR introduce?
What is the current behavior?
@waterplea sorry, but
mousedown
fixed focus, but now it doesn't respond at allhttps://taiga-ui.dev/next/editor/API