Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-editor): add pretty bottom indent for content editable area #4460

Merged
merged 3 commits into from
May 16, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #4457

What is the new behavior?

image image

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 16, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented May 16, 2023

BundleMon

Unchanged files (6)
Status Path Size Limits
demo/browser/main.(hash).js
324.46KB +10%
demo/browser/vendor.(hash).js
197.37KB +10%
demo/browser/runtime.(hash).js
37.8KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change -2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.23MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

Visit the preview URL for this PR (updated for commit 7034427):

https://taiga-ui--pr4460-splincode-fix-issues-jq4afwr2.web.app

(expires Wed, 17 May 2023 13:47:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.50 ⚠️

Comparison is base (96999bf) 70.32% compared to head (a05258a) 69.83%.

❗ Current head a05258a differs from pull request most recent head 2b2dbeb. Consider uploading reports for the commit 2b2dbeb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4460      +/-   ##
==========================================
- Coverage   70.32%   69.83%   -0.50%     
==========================================
  Files        1511     1560      +49     
  Lines       16524    17094     +570     
  Branches     2344     2404      +60     
==========================================
+ Hits        11620    11937     +317     
- Misses       4516     4762     +246     
- Partials      388      395       +7     
Flag Coverage Δ
addon-charts 71.41% <ø> (-15.32%) ⬇️
addon-doc 51.72% <ø> (ø)
addon-editor 49.87% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.41% <ø> (ø)
core 76.85% <ø> (ø)
kit 72.12% <ø> (ø)
summary 69.83% <ø> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 49 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -51,6 +51,7 @@
display: flex;
max-height: inherit;
border-top: 1.625rem solid transparent;
border-bottom: 1px solid transparent;
border-bottom: 0.3125rem solid transparent;
padding-bottom: calc(1.625rem - 0.3125rem);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary calc

@splincode splincode force-pushed the splincode/fix/issues/4457 branch from 2b2dbeb to 7034427 Compare May 16, 2023 13:39
@splincode splincode merged commit 2f5d2a8 into main May 16, 2023
@splincode splincode deleted the splincode/fix/issues/4457 branch May 16, 2023 13:40
@well-done-bot
Copy link

well-done-bot bot commented May 16, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - Add a small bottom padding like in textarea for tui-editor
2 participants