Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Prompt wrap buttons to the new line if they do not fit #4443

Merged
merged 5 commits into from
May 15, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #4439

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 12, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

Visit the preview URL for this PR (updated for commit 41886f5):

https://taiga-ui--pr4443-prompt-7g7b819w.web.app

(expires Tue, 16 May 2023 13:27:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented May 12, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
324.38KB (+61B +0.02%) +10%
demo/browser/runtime.(hash).js
37.68KB (+45B +0.12%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
197.37KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +106B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.23MB (+3.28KB +0.14%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.92 🎉

Comparison is base (365a136) 60.90% compared to head (41886f5) 69.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4443      +/-   ##
==========================================
+ Coverage   60.90%   69.82%   +8.92%     
==========================================
  Files        1653     1558      -95     
  Lines       19339    17086    -2253     
  Branches     2758     2404     -354     
==========================================
+ Hits        11778    11930     +152     
+ Misses       7064     4761    -2303     
+ Partials      497      395     -102     
Flag Coverage Δ
addon-charts 71.41% <ø> (-1.56%) ⬇️
addon-doc 51.41% <ø> (ø)
addon-editor 49.87% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.19% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 81.41% <ø> (+41.56%) ⬆️
core 76.85% <ø> (ø)
kit 72.12% <ø> (ø)
summary 69.82% <ø> (+8.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/prompt/prompt.component.ts 66.66% <ø> (ø)

... and 122 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode
Copy link
Member

is it expected?

image

@waterplea
Copy link
Collaborator Author

is it expected?

image

A necessary evil.

@splincode splincode merged commit 63ed120 into main May 15, 2023
@splincode splincode deleted the prompt branch May 15, 2023 14:35
@well-done-bot
Copy link

well-done-bot bot commented May 15, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - PromptDialog: buttons don't look good on mobile devices.
4 participants