feat(addon-commerce): InputCard uses Maskito instead of legacy text-mask
#4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsbarsukov
requested review from
waterplea,
MarsiBarsi,
vladimirpotekhin and
splincode
as code owners
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
nsbarsukov
commented
May 5, 2023
projects/addon-commerce/components/input-card/input-card.component.ts
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit bcd235c): https://taiga-ui--pr4385-maskito-input-card-mz88kde6.web.app (expires Sat, 06 May 2023 08:54:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (1)
Unchanged files (5)
Total files change +62B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4385 +/- ##
==========================================
- Coverage 61.07% 61.06% -0.01%
==========================================
Files 1650 1650
Lines 19313 19309 -4
Branches 2746 2745 -1
==========================================
- Hits 11796 11792 -4
Misses 7029 7029
Partials 488 488
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
splincode
reviewed
May 5, 2023
projects/addon-commerce/components/input-card/test/input-card.component.spec.ts
Show resolved
Hide resolved
waterplea
reviewed
May 5, 2023
projects/addon-commerce/components/input-card/input-card.component.ts
Outdated
Show resolved
Hide resolved
@waterplea I will do it in next separate PR |
waterplea
approved these changes
May 5, 2023
vladimirpotekhin
approved these changes
May 10, 2023
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Partially solves #120
Does this PR introduce a breaking change?