Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): Tag add button selector #4251

Merged
merged 2 commits into from
Apr 20, 2023
Merged

feat(kit): Tag add button selector #4251

merged 2 commits into from
Apr 20, 2023

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 19, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2023

Visit the preview URL for this PR (updated for commit 0bc6e35):

https://taiga-ui--pr4251-small-fixes-mszflzwp.web.app

(expires Thu, 20 Apr 2023 14:16:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Apr 19, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
37.12KB (-14B -0.04%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
322.59KB +10%
demo/browser/vendor.(hash).js
190.89KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%

Total files change -15B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.16MB (-271B -0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e585e7) 61.36% compared to head (0bc6e35) 61.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4251   +/-   ##
=======================================
  Coverage   61.36%   61.36%           
=======================================
  Files        1630     1630           
  Lines       19099    19099           
  Branches     2699     2699           
=======================================
  Hits        11721    11721           
  Misses       6896     6896           
  Partials      482      482           
Flag Coverage Δ
addon-charts 72.03% <ø> (ø)
addon-doc 50.27% <ø> (ø)
addon-editor 49.51% <ø> (ø)
addon-mobile 62.47% <ø> (ø)
addon-table 61.06% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 41.03% <ø> (ø)
core 76.98% <ø> (ø)
kit 72.62% <ø> (ø)
summary 61.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/tag/tag.component.ts 87.69% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode changed the title chore: small fixes feat(kit): Tag add button selector Apr 19, 2023
@splincode splincode merged commit 856bc57 into main Apr 20, 2023
@splincode splincode deleted the small-fixes branch April 20, 2023 10:34
@well-done-bot
Copy link

well-done-bot bot commented Apr 20, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants