Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): support autofill values when trigger autofocus on iOS #4160

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Apr 8, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #4129

What is the new behavior?

MacOS safari

Screen.Recording.2023-04-08.at.16.08.25.mov

iOS safari:


IMG_7567.MOV

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 8, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Apr 8, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
340.21KB (+106B +0.03%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.47KB +10%
demo/browser/runtime.(hash).js
37.04KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +105B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (+397B +0.02%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

Visit the preview URL for this PR (updated for commit 4dcaadc):

https://taiga-ui--pr4160-splincode-fix-issues-gyldv3lh.web.app

(expires Tue, 11 Apr 2023 06:46:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.01 ⚠️

Comparison is base (faa35a4) 61.33% compared to head (4dcaadc) 61.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4160      +/-   ##
==========================================
- Coverage   61.33%   61.33%   -0.01%     
==========================================
  Files        1613     1613              
  Lines       18959    18964       +5     
  Branches     2661     2662       +1     
==========================================
+ Hits        11629    11631       +2     
- Misses       6852     6854       +2     
- Partials      478      479       +1     
Flag Coverage Δ
addon-charts 72.03% <ø> (ø)
addon-doc 50.16% <ø> (ø)
addon-editor 49.46% <ø> (ø)
addon-mobile 61.88% <ø> (ø)
addon-table 61.06% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.90% <25.00%> (-0.02%) ⬇️
core 76.96% <ø> (ø)
kit 72.71% <ø> (+<0.01%) ⬆️
summary 61.33% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cdk/directives/auto-focus/handlers/ios.handler.ts 13.11% <25.00%> (+0.83%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/issues/4129 branch from a75ed21 to 4dcaadc Compare April 10, 2023 06:39
@splincode splincode merged commit f696de6 into main Apr 10, 2023
@splincode splincode deleted the splincode/fix/issues/4129 branch April 10, 2023 07:45
@well-done-bot
Copy link

well-done-bot bot commented Apr 10, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants