Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): clear timeout for tuiForAsync #4139

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Apr 6, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #4101

What is the new behavior?

Improve search UX in icons page

Screen.Recording.2023-04-07.at.01.29.58.mov

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 6, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Apr 6, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
341.45KB (+43B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.47KB +10%
demo/browser/runtime.(hash).js
36.99KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +41B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (+276B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Visit the preview URL for this PR (updated for commit c5b4286):

https://taiga-ui--pr4139-splincode-refactor-i-pyr9unl3.web.app

(expires Sat, 08 Apr 2023 09:05:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4053f45) 61.34% compared to head (c5b4286) 61.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4139   +/-   ##
=======================================
  Coverage   61.34%   61.34%           
=======================================
  Files        1613     1613           
  Lines       18947    18949    +2     
  Branches     2592     2593    +1     
=======================================
+ Hits        11623    11625    +2     
  Misses       6847     6847           
  Partials      477      477           
Flag Coverage Δ
addon-charts 72.03% <ø> (ø)
addon-doc 50.16% <ø> (ø)
addon-editor 49.46% <ø> (ø)
addon-mobile 61.88% <ø> (ø)
addon-table 61.06% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.91% <100.00%> (+0.02%) ⬆️
core 76.98% <ø> (ø)
kit 72.74% <ø> (ø)
summary 61.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/cdk/directives/for-async/for-async.directive.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/refactor/issues/4101 branch from 64fdae1 to 502fd62 Compare April 7, 2023 09:01
@splincode splincode force-pushed the splincode/refactor/issues/4101 branch from 502fd62 to c5b4286 Compare April 7, 2023 09:01
@splincode splincode requested a review from waterplea April 7, 2023 09:01
@splincode splincode merged commit 33c6224 into main Apr 7, 2023
@splincode splincode deleted the splincode/refactor/issues/4101 branch April 7, 2023 12:27
@well-done-bot
Copy link

well-done-bot bot commented Apr 7, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🤖 - Improve icons search
3 participants