-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): Stepper
use TuiScrollService
instead of scrollIntoView
#4123
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 7a6feca): https://taiga-ui--pr4123-stepper-fix-3v2kgihn.web.app (expires Fri, 07 Apr 2023 13:33:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +146B +0.02% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4123 +/- ##
==========================================
- Coverage 61.35% 61.31% -0.04%
==========================================
Files 1613 1613
Lines 18951 18960 +9
Branches 2593 2592 -1
==========================================
- Hits 11627 11626 -1
- Misses 6848 6857 +9
- Partials 476 477 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
66e7b76
to
cde73c0
Compare
5efd33f
to
7a6feca
Compare
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3629
There is a chromium bug with
element.scrollIntoView
https://bugs.chromium.org/p/chromium/issues/detail?id=833617Autoscroll doesn't work if there is more then one stepper on the page
What is the new behavior?
With
TuiScrollService
scroll works correctlyDoes this PR introduce a breaking change?