Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Stepper use TuiScrollService instead of scrollIntoView #4123

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3629

There is a chromium bug with element.scrollIntoView https://bugs.chromium.org/p/chromium/issues/detail?id=833617
Autoscroll doesn't work if there is more then one stepper on the page

What is the new behavior?

With TuiScrollService scroll works correctly

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Apr 5, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Visit the preview URL for this PR (updated for commit 7a6feca):

https://taiga-ui--pr4123-stepper-fix-3v2kgihn.web.app

(expires Fri, 07 Apr 2023 13:33:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Apr 5, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
341.6KB (+121B +0.03%) +10%
demo/browser/runtime.(hash).js
36.98KB (+25B +0.07%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.16KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +146B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (+915B +0.04%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (b381f3d) 61.35% compared to head (7a6feca) 61.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4123      +/-   ##
==========================================
- Coverage   61.35%   61.31%   -0.04%     
==========================================
  Files        1613     1613              
  Lines       18951    18960       +9     
  Branches     2593     2592       -1     
==========================================
- Hits        11627    11626       -1     
- Misses       6848     6857       +9     
- Partials      476      477       +1     
Flag Coverage Δ
addon-charts 72.03% <ø> (ø)
addon-doc 50.16% <ø> (ø)
addon-editor 49.46% <ø> (ø)
addon-mobile 61.82% <ø> (ø)
addon-table 61.06% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.89% <ø> (ø)
core 76.89% <ø> (ø)
kit 72.68% <0.00%> (-0.14%) ⬇️
summary 61.31% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ojects/kit/components/stepper/stepper.component.ts 17.30% <0.00%> (-5.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin merged commit 3eef359 into main Apr 7, 2023
@vladimirpotekhin vladimirpotekhin deleted the stepper-fix branch April 7, 2023 06:53
@well-done-bot
Copy link

well-done-bot bot commented Apr 7, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - When current step is not the 1st Stepper doesn't scroll to active step
3 participants