Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Link delete wrong icon opacity #4069

Merged
merged 1 commit into from
Apr 1, 2023
Merged

fix(core): Link delete wrong icon opacity #4069

merged 1 commit into from
Apr 1, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #4029

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 31, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Mar 31, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
339.19KB (-24B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.13KB +10%
demo/browser/runtime.(hash).js
36.55KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change -24B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.2MB (-24B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit eedca0a):

https://taiga-ui--pr4069-fix-link-style-62ifo7u8.web.app

(expires Sat, 01 Apr 2023 14:00:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f49df01) 61.27% compared to head (eedca0a) 61.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4069   +/-   ##
=======================================
  Coverage   61.27%   61.27%           
=======================================
  Files        1593     1593           
  Lines       18836    18836           
  Branches     2593     2593           
=======================================
  Hits        11541    11541           
  Misses       6816     6816           
  Partials      479      479           
Flag Coverage Δ
addon-charts 72.01% <ø> (ø)
addon-doc 49.65% <ø> (ø)
addon-editor 49.43% <ø> (ø)
addon-mobile 61.73% <ø> (ø)
addon-table 60.21% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.56% <ø> (ø)
core 76.87% <ø> (ø)
kit 72.72% <ø> (ø)
summary 61.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea
Copy link
Collaborator

Do we really not have any screenshots with link + icon?

@splincode splincode merged commit 174c02e into main Apr 1, 2023
@splincode splincode deleted the fix-link-style branch April 1, 2023 06:02
@well-done-bot
Copy link

well-done-bot bot commented Apr 1, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Link icon has wrong opacity
3 participants