Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Google Chrome fires keydown event when form autocomplete #3964

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3959

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 23, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Mar 23, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
336.88KB +10%
demo/browser/vendor.(hash).js
200.25KB +10%
demo/browser/runtime.(hash).js
36.37KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +9B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.18MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit b56b670):

https://taiga-ui--pr3964-splincode-fix-issues-n1ds9onl.web.app

(expires Fri, 24 Mar 2023 10:56:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a175c81) 61.25% compared to head (b56b670) 61.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3964   +/-   ##
=======================================
  Coverage   61.25%   61.25%           
=======================================
  Files        1588     1588           
  Lines       18758    18758           
  Branches     2585     2585           
=======================================
  Hits        11490    11490           
  Misses       6790     6790           
  Partials      478      478           
Flag Coverage Δ
addon-charts 72.01% <ø> (ø)
addon-doc 49.65% <ø> (ø)
addon-editor 49.43% <ø> (ø)
addon-mobile 61.73% <ø> (ø)
addon-table 60.21% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.53% <ø> (ø)
core 76.82% <100.00%> (ø)
kit 72.87% <ø> (ø)
summary 61.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/hosted-dropdown/hosted-dropdown.component.ts 83.56% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode requested a review from waterplea March 23, 2023 11:41
@splincode splincode merged commit 3444080 into main Mar 23, 2023
@splincode splincode deleted the splincode/fix/issues/3959 branch March 23, 2023 13:52
@well-done-bot
Copy link

well-done-bot bot commented Mar 23, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Ошибка при создании текстовых полей с автоподстановкой
3 participants