Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-mobile): Sheet disable scroll snap for Firefox #3946

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3796

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 22, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023

Visit the preview URL for this PR (updated for commit 86e24b8):

https://taiga-ui--pr3946-firefox-faynsvrw.web.app

(expires Thu, 23 Mar 2023 05:49:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Mar 22, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
336.27KB (+15B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.25KB +10%
demo/browser/runtime.(hash).js
36.38KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +6B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.18MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 43.75% and project coverage change: +6.66 🎉

Comparison is base (92c5f00) 61.26% compared to head (86e24b8) 67.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3946      +/-   ##
==========================================
+ Coverage   61.26%   67.93%   +6.66%     
==========================================
  Files        1585     1179     -406     
  Lines       18735    14174    -4561     
  Branches     2582     1952     -630     
==========================================
- Hits        11478     9629    -1849     
+ Misses       6778     4210    -2568     
+ Partials      479      335     -144     
Flag Coverage Δ
addon-charts 72.01% <ø> (ø)
addon-doc 49.52% <ø> (ø)
addon-editor 49.43% <ø> (ø)
addon-mobile 61.73% <43.75%> (-0.05%) ⬇️
addon-table 60.21% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk ∅ <ø> (∅)
core 76.92% <ø> (ø)
kit 72.87% <ø> (ø)
summary 67.93% <43.75%> (+6.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...irectives/sheet-wrapper/sheet-wrapper.directive.ts 44.44% <30.76%> (-12.70%) ⬇️
...rojects/addon-mobile/components/sheet/ios.hacks.ts 21.73% <100.00%> (+1.73%) ⬆️

... and 406 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode
Copy link
Member

splincode commented Mar 22, 2023

Is it expected?

Don't open in first time:

Screen.Recording.2023-03-22.at.09.24.11.mov

Dark corners:
Screen.Recording.2023-03-22.at.09.25.06.mov

Does not always expand in height immediately:
Screen.Recording.2023-03-22.at.09.25.56.mov

@waterplea
Copy link
Collaborator Author

@splincode it's best to test on real mobile device. Unfortunately there's a lot of issues on Firefox I couldn't solve. We could try to solve not opening it for the first time but as a separate issue because I can no longer spend time on mobile Firefox as it seems to account for about 0.5% of users. Problem with it not opening the first time is image loading and changing dimensions, I believe.

@splincode splincode merged commit 411a58a into main Mar 23, 2023
@splincode splincode deleted the firefox branch March 23, 2023 08:12
@well-done-bot
Copy link

well-done-bot bot commented Mar 23, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Sheet is closing on click on content in firefox
3 participants