-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(addon-mobile): Sheet
disable scroll snap for Firefox
#3946
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 86e24b8): https://taiga-ui--pr3946-firefox-faynsvrw.web.app (expires Thu, 23 Mar 2023 05:49:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +6B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3946 +/- ##
==========================================
+ Coverage 61.26% 67.93% +6.66%
==========================================
Files 1585 1179 -406
Lines 18735 14174 -4561
Branches 2582 1952 -630
==========================================
- Hits 11478 9629 -1849
+ Misses 6778 4210 -2568
+ Partials 479 335 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 406 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Is it expected? Don't open in first time: Screen.Recording.2023-03-22.at.09.24.11.movDark corners: Screen.Recording.2023-03-22.at.09.25.06.movDoes not always expand in height immediately: Screen.Recording.2023-03-22.at.09.25.56.mov |
@splincode it's best to test on real mobile device. Unfortunately there's a lot of issues on Firefox I couldn't solve. We could try to solve not opening it for the first time but as a separate issue because I can no longer spend time on mobile Firefox as it seems to account for about 0.5% of users. Problem with it not opening the first time is image loading and changing dimensions, I believe. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3796
What is the new behavior?
Does this PR introduce a breaking change?