Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputTime fix wrong preudofocus state #3896

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3885

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 17, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Mar 17, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
335.98KB (-13B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.25KB +10%
demo/browser/runtime.(hash).js
36.37KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change -13B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (-13B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 7d02100):

https://taiga-ui--pr3896-input-time-fix-wrtcspg1.web.app

(expires Sat, 18 Mar 2023 11:14:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.70 ⚠️

Comparison is base (7e136dc) 67.94% compared to head (7d02100) 61.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3896      +/-   ##
==========================================
- Coverage   67.94%   61.25%   -6.70%     
==========================================
  Files        1178     1582     +404     
  Lines       14156    18709    +4553     
  Branches     1952     2584     +632     
==========================================
+ Hits         9619    11460    +1841     
- Misses       4203     6770    +2567     
- Partials      334      479     +145     
Flag Coverage Δ
addon-charts 72.01% <ø> (ø)
addon-doc 49.76% <ø> (ø)
addon-editor 49.45% <ø> (ø)
addon-mobile 61.77% <ø> (ø)
addon-table 60.21% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.41% <ø> (∅)
core 76.89% <ø> (-0.02%) ⬇️
kit 72.84% <100.00%> (+<0.01%) ⬆️
summary 61.25% <100.00%> (-6.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../kit/components/input-time/input-time.component.ts 84.76% <100.00%> (+0.14%) ⬆️

... and 407 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode merged commit dea3de7 into main Mar 17, 2023
@splincode splincode deleted the input-time-fix branch March 17, 2023 12:06
@well-done-bot
Copy link

well-done-bot bot commented Mar 17, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - InputTime looks like focused when it is not
3 participants