Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): use ellipsis for label in pdf-viewer when overflow text #3845

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

splincode
Copy link
Member

@splincode splincode commented Mar 12, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3837

What is the new behavior?

image

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 12, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Mar 12, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
335.11KB +10%
demo/browser/vendor.(hash).js
200.25KB +10%
demo/browser/runtime.(hash).js
36.21KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +7B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2023

Visit the preview URL for this PR (updated for commit f147d25):

https://taiga-ui--pr3845-splincode-fix-issues-11rsdr76.web.app

(expires Tue, 14 Mar 2023 10:24:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.43 ⚠️

Comparison is base (56fc440) 62.69% compared to head (f147d25) 61.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3845      +/-   ##
==========================================
- Coverage   62.69%   61.27%   -1.43%     
==========================================
  Files        1101     1579     +478     
  Lines       13199    18667    +5468     
  Branches     1921     2575     +654     
==========================================
+ Hits         8275    11438    +3163     
- Misses       4564     6755    +2191     
- Partials      360      474     +114     
Flag Coverage Δ
addon-charts 72.01% <ø> (?)
addon-doc 49.76% <ø> (?)
addon-editor 49.58% <ø> (?)
addon-mobile 61.77% <ø> (?)
addon-table 60.21% <ø> (?)
addon-tablebars 98.11% <ø> (?)
cdk 40.32% <ø> (ø)
core 76.94% <ø> (-0.04%) ⬇️
kit 72.89% <ø> (ø)
summary 61.27% <ø> (-1.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 480 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin
Copy link
Member

nit: don't we need a little space between text and action-button?

@splincode
Copy link
Member Author

nit: don't we need a little space between text and action-button? how many pixels is needed?

@splincode splincode force-pushed the splincode/fix/issues/3837 branch from ee40755 to f147d25 Compare March 13, 2023 10:20
@vladimirpotekhin
Copy link
Member

how many pixels is needed?

looks good now 👍

@splincode splincode merged commit dd308ac into main Mar 13, 2023
@splincode splincode deleted the splincode/fix/issues/3837 branch March 13, 2023 10:51
@well-done-bot
Copy link

well-done-bot bot commented Mar 13, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - TuiPdfViewerService does not support long label
3 participants