-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kit): use ellipsis for label in pdf-viewer
when overflow text
#3845
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonUnchanged files (5)
Total files change +7B 0% Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit f147d25): https://taiga-ui--pr3845-splincode-fix-issues-11rsdr76.web.app (expires Tue, 14 Mar 2023 10:24:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3845 +/- ##
==========================================
- Coverage 62.69% 61.27% -1.43%
==========================================
Files 1101 1579 +478
Lines 13199 18667 +5468
Branches 1921 2575 +654
==========================================
+ Hits 8275 11438 +3163
- Misses 4564 6755 +2191
- Partials 360 474 +114
Flags with carried forward coverage won't be shown. Click here to find out more. see 480 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
nit: don't we need a little space between text and action-button? |
|
ee40755
to
f147d25
Compare
looks good now 👍 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3837
What is the new behavior?
Does this PR introduce a breaking change?