Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add example with named outlets #3821

Merged
merged 6 commits into from
Mar 9, 2023

Conversation

Reactiver
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

No documentation how to use routable dialogs with named outlets.

Closes #

What is the new behavior?

Added example how to use routable dialog with named outlets.

Does this PR introduce a breaking change?

  • Yes
  • No

@Reactiver Reactiver marked this pull request as draft March 8, 2023 05:17
@lumberjack-bot
Copy link

lumberjack-bot bot commented Mar 8, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Mar 8, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/runtime.(hash).js
36.2KB (+58B +0.16%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
336.66KB +10%
demo/browser/vendor.(hash).js
204.37KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +58B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.3MB (+2.21KB +0.09%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Reactiver Reactiver force-pushed the feat/named-routable-dialog branch from f733b30 to d489956 Compare March 8, 2023 10:23
package.json Outdated Show resolved Hide resolved
@Reactiver Reactiver marked this pull request as ready for review March 8, 2023 10:39
@Reactiver Reactiver changed the title [WIP] feat(demo): add example with named outlets feat(demo): add example with named outlets Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (886f588) 61.29% compared to head (14d8090) 61.29%.

❗ Current head 14d8090 differs from pull request most recent head 51a7704. Consider uploading reports for the commit 51a7704 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3821   +/-   ##
=======================================
  Coverage   61.29%   61.29%           
=======================================
  Files        1579     1579           
  Lines       18688    18688           
  Branches     2584     2584           
=======================================
  Hits        11455    11455           
  Misses       6758     6758           
  Partials      475      475           
Flag Coverage Δ
addon-charts 72.01% <ø> (ø)
addon-doc 49.76% <ø> (ø)
addon-editor 49.58% <ø> (ø)
addon-mobile 61.77% <ø> (ø)
addon-table 60.21% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.32% <ø> (ø)
core 76.97% <ø> (ø)
kit 72.90% <ø> (ø)
summary 61.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Reactiver Reactiver force-pushed the feat/named-routable-dialog branch from 14d8090 to 03c88ab Compare March 9, 2023 13:51
@splincode splincode merged commit 5e897f7 into taiga-family:main Mar 9, 2023
@well-done-bot
Copy link

well-done-bot bot commented Mar 9, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants