Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Hint/Dropdown fix directives order mattering #3726

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2494
Closes #3097

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Feb 20, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Feb 20, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
338.94KB (+622B +0.18%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.37KB +10%
demo/browser/runtime.(hash).js
36.09KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
18.08KB +10%

Total files change +624B +0.1%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.3MB (+600B +0.02%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

Visit the preview URL for this PR (updated for commit c8cfd43):

https://taiga-ui--pr3726-multify-tokens-phipx613.web.app

(expires Thu, 23 Feb 2023 05:11:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode
Copy link
Member

splincode commented Feb 20, 2023

  • pie-chart.cy.ts
  • eslint hint.providers.ts

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 61.24% // Head: 61.30% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c8cfd43) compared to base (4452896).
Patch coverage: 76.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3726      +/-   ##
==========================================
+ Coverage   61.24%   61.30%   +0.05%     
==========================================
  Files        1578     1578              
  Lines       18624    18677      +53     
  Branches     2577     2582       +5     
==========================================
+ Hits        11407    11450      +43     
- Misses       6742     6752      +10     
  Partials      475      475              
Flag Coverage Δ
addon-charts 72.01% <ø> (ø)
addon-doc 49.76% <ø> (ø)
addon-editor 49.58% <0.00%> (-0.03%) ⬇️
addon-mobile 61.77% <ø> (ø)
addon-table 60.21% <ø> (ø)
addon-tablebars 98.11% <ø> (ø)
cdk 40.32% <ø> (ø)
core 76.97% <79.56%> (+0.14%) ⬆️
kit 72.95% <40.00%> (-0.03%) ⬇️
summary 61.30% <76.76%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/editor/portal/editor-portal.directive.ts 55.55% <0.00%> (-6.95%) ⬇️
projects/core/abstract/vehicle.ts 100.00% <ø> (ø)
.../directives/dropdown/dropdown-context.directive.ts 37.50% <0.00%> (-2.50%) ⬇️
...re/directives/dropdown/dropdown-hover.directive.ts 36.84% <0.00%> (-2.05%) ⬇️
...irectives/dropdown/dropdown-selection.directive.ts 13.15% <0.00%> (-0.18%) ⬇️
...ojects/core/directives/hint/hint-host.directive.ts 66.66% <0.00%> (-13.34%) ⬇️
projects/core/directives/hint/hint.providers.ts 100.00% <ø> (ø)
projects/core/tokens/viewport.ts 75.00% <ø> (ø)
...cts/core/directives/dropdown/dropdown.component.ts 45.45% <16.66%> (ø)
...ts/core/directives/hint/hint-describe.directive.ts 38.09% <25.00%> (-1.04%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea waterplea merged commit 263c713 into main Feb 22, 2023
@waterplea waterplea deleted the multify-tokens branch February 22, 2023 09:48
@well-done-bot
Copy link

well-done-bot bot commented Feb 22, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants