-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(addon-editor): support hilite groups #3283
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit 49f8516): https://taiga-ui--pr3283-splincode-feat-issue-chz3h0tl.web.app (expires Sat, 31 Dec 2022 16:54:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change -12B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
bbb7000
to
b7e4b74
Compare
Codecov ReportBase: 61.44% // Head: 61.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
- Coverage 61.44% 61.40% -0.05%
==========================================
Files 1534 1534
Lines 18117 18133 +16
Branches 2527 2528 +1
==========================================
+ Hits 11132 11134 +2
- Misses 6524 6535 +11
- Partials 461 464 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
14fe560
to
0e0f7be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have that bucket icon in proprietary package? Also I think we should combine those into 1 page "Groups" with 3 examples:
Draggable groups
Hilite groups
Nested groups
projects/addon-editor/components/toolbar-tools/group/group.component.ts
Outdated
Show resolved
Hide resolved
projects/addon-editor/components/toolbar-tools/group/group.component.ts
Outdated
Show resolved
Hide resolved
Probably makes sense to add |
04a56a1
to
532eeff
Compare
156acc7
to
616380d
Compare
616380d
to
49f8516
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?