Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-editor): support hilite groups #3283

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 22, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode changed the title chore(demo): add example for filled groups [WIP] chore(demo): add example for filled groups Dec 22, 2022
@splincode splincode marked this pull request as draft December 22, 2022 08:55
@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2022

Visit the preview URL for this PR (updated for commit 49f8516):

https://taiga-ui--pr3283-splincode-feat-issue-chz3h0tl.web.app

(expires Sat, 31 Dec 2022 16:54:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Dec 22, 2022

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
332.48KB (-16B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.01KB +10%
demo/browser/runtime.(hash).js
34.92KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change -12B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.21MB (-866B -0.04%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/feat/issues/3142 branch from bbb7000 to b7e4b74 Compare December 23, 2022 14:35
@splincode splincode changed the title [WIP] chore(demo): add example for filled groups feat(addon-editor): support hilite groups Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 61.44% // Head: 61.40% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (14fe560) compared to base (d82f991).
Patch coverage: 22.58% of modified lines in pull request are covered.

❗ Current head 14fe560 differs from pull request most recent head 49f8516. Consider uploading reports for the commit 49f8516 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
- Coverage   61.44%   61.40%   -0.05%     
==========================================
  Files        1534     1534              
  Lines       18117    18133      +16     
  Branches     2527     2528       +1     
==========================================
+ Hits        11132    11134       +2     
- Misses       6524     6535      +11     
- Partials      461      464       +3     
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 50.00% <ø> (ø)
addon-editor 50.73% <22.58%> (-0.51%) ⬇️
addon-mobile 62.31% <ø> (ø)
addon-table 60.70% <ø> (-0.09%) ⬇️
addon-tablebars 98.07% <ø> (ø)
cdk 39.90% <ø> (ø)
core 77.05% <ø> (+0.20%) ⬆️
kit 73.02% <ø> (-0.02%) ⬇️
summary 61.40% <22.58%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/addon-editor/abstract/editor-adapter.abstract.ts 60.00% <ø> (ø)
.../directives/tiptap-editor/tiptap-editor.service.ts 9.00% <0.00%> (-0.10%) ⬇️
...s/addon-editor/extensions/group/group.extension.ts 8.00% <0.00%> (-4.13%) ⬇️
.../components/toolbar-tools/group/group.component.ts 40.00% <42.85%> (-6.67%) ⬇️
...tor/components/toolbar-tools/group/group.module.ts 100.00% <100.00%> (ø)
projects/addon-editor/enums/editor-tool.ts 100.00% <100.00%> (ø)
...cts/core/components/calendar/calendar.component.ts 89.18% <0.00%> (-5.94%) ⬇️
...ts/kit/components/input-tag/input-tag.component.ts 73.58% <0.00%> (-4.00%) ⬇️
...ives/dropdown/dropdown-position-sided.directive.ts 42.85% <0.00%> (-1.98%) ⬇️
...ojects/kit/directives/present/present.directive.ts 33.33% <0.00%> (-1.97%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode marked this pull request as ready for review December 23, 2022 14:49
@splincode splincode force-pushed the splincode/feat/issues/3142 branch 2 times, most recently from 14fe560 to 0e0f7be Compare December 23, 2022 18:39
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have that bucket icon in proprietary package? Also I think we should combine those into 1 page "Groups" with 3 examples:

Draggable groups
Hilite groups
Nested groups

@waterplea
Copy link
Collaborator

Probably makes sense to add transparent or Remove color option.

@splincode splincode force-pushed the splincode/feat/issues/3142 branch 2 times, most recently from 04a56a1 to 532eeff Compare December 26, 2022 16:13
@splincode splincode force-pushed the splincode/feat/issues/3142 branch 7 times, most recently from 156acc7 to 616380d Compare December 30, 2022 16:23
@splincode splincode force-pushed the splincode/feat/issues/3142 branch from 616380d to 49f8516 Compare December 30, 2022 16:38
@splincode splincode merged commit c632052 into main Dec 30, 2022
@splincode splincode deleted the splincode/feat/issues/3142 branch December 30, 2022 17:18
@well-done-bot
Copy link

well-done-bot bot commented Dec 30, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - Блок для выделения важной информации
2 participants