Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): Schematics add root path option #3274

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 21, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Dec 21, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
332.23KB +10%
demo/browser/vendor.(hash).js
204.86KB +10%
demo/browser/runtime.(hash).js
34.81KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.21MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit dd8d9a6):

https://taiga-ui--pr3274-schematic-root-t0hdde8r.web.app

(expires Thu, 22 Dec 2022 14:20:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 61.49% // Head: 61.47% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (dd8d9a6) compared to base (b5bfe4f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
- Coverage   61.49%   61.47%   -0.03%     
==========================================
  Files        1532     1533       +1     
  Lines       18090    18096       +6     
  Branches     2523     2524       +1     
==========================================
  Hits        11124    11124              
- Misses       6507     6512       +5     
- Partials      459      460       +1     
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 49.93% <ø> (ø)
addon-editor 51.23% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.70% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 39.90% <0.00%> (-0.05%) ⬇️
core 77.05% <ø> (ø)
kit 73.02% <ø> (-0.02%) ⬇️
summary 61.47% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cdk/schematics/ng-update/utils/get-file-system.ts 0.00% <0.00%> (ø)
.../schematics/ng-update/v3/steps/migrate-progress.ts 0.00% <0.00%> (ø)
...te/v3/steps/migrate-sliders/migrate-input-range.ts 0.00% <0.00%> (ø)
...e/v3/steps/migrate-sliders/migrate-input-slider.ts 0.00% <0.00%> (ø)
projects/cdk/schematics/utils/project-root.ts 0.00% <0.00%> (ø)
...wn-manager/data-list-dropdown-manager.directive.ts 18.51% <0.00%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea
Copy link
Collaborator

It will work ok if the root folder is not a project root, right? I mean if it has no package.json/angular.json in that folder and somebody just wants to run migrations for a particular folder?

@vladimirpotekhin
Copy link
Member Author

It will work ok if the root folder is not a project root, right? I mean if it has no package.json/angular.json in that folder and somebody just wants to run migrations for a particular folder?

yes, it should work for particular folder without *.json

@vladimirpotekhin vladimirpotekhin merged commit 00a0e4d into main Dec 22, 2022
@vladimirpotekhin vladimirpotekhin deleted the schematic-root branch December 22, 2022 14:06
@well-done-bot
Copy link

well-done-bot bot commented Dec 22, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants