Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): SortCountries add pipe for InputPhoneInternational #3257

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

waterplea
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3227

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 19, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Dec 19, 2022

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
331.56KB (+436B +0.13%) +10%
demo/browser/runtime.(hash).js
34.65KB (+129B +0.36%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.86KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +565B +0.09%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.19MB (+4.23KB +0.19%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022

Visit the preview URL for this PR (updated for commit 8c078e6):

https://taiga-ui--pr3257-flags-mwef1oup.web.app

(expires Tue, 20 Dec 2022 09:25:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Base: 61.48% // Head: 61.49% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8c078e6) compared to base (cdb9c05).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3257   +/-   ##
=======================================
  Coverage   61.48%   61.49%           
=======================================
  Files        1525     1532    +7     
  Lines       18048    18090   +42     
  Branches     2522     2523    +1     
=======================================
+ Hits        11097    11124   +27     
- Misses       6494     6507   +13     
- Partials      457      459    +2     
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 49.93% <ø> (+1.20%) ⬆️
addon-editor 51.23% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.70% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 39.94% <ø> (-0.07%) ⬇️
core 77.05% <ø> (ø)
kit 73.04% <73.33%> (+<0.01%) ⬆️
summary 61.49% <73.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ternational/input-phone-international.component.ts 93.24% <0.00%> (-1.28%) ⬇️
...ts/kit/pipes/sort-countries/sort-countries.pipe.ts 62.50% <62.50%> (ø)
projects/kit/pipes/index.ts 100.00% <100.00%> (ø)
projects/kit/pipes/sort-countries/index.ts 100.00% <100.00%> (ø)
.../kit/pipes/sort-countries/sort-countries.module.ts 100.00% <100.00%> (ø)
projects/cdk/directives/index.ts 100.00% <0.00%> (ø)
projects/cdk/services/resize.service.ts 100.00% <0.00%> (ø)
projects/cdk/directives/drag/drag.module.ts 100.00% <0.00%> (ø)
projects/cdk/directives/drag/drag.directive.ts 26.66% <0.00%> (ø)
projects/cdk/schematics/constants/file-globs.ts 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vladimirpotekhin vladimirpotekhin merged commit ffb6cd1 into main Dec 19, 2022
@vladimirpotekhin vladimirpotekhin deleted the flags branch December 19, 2022 11:57
@well-done-bot
Copy link

well-done-bot bot commented Dec 19, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - InputPhoneInternational flags are missing
3 participants