Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): fix dutch translations for multiSelectTexts #3211

Merged
merged 2 commits into from
Dec 12, 2022
Merged

fix(i18n): fix dutch translations for multiSelectTexts #3211

merged 2 commits into from
Dec 12, 2022

Conversation

jsprw
Copy link
Contributor

@jsprw jsprw commented Dec 9, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Current texts are in Norwegian (I guess?) instead of Dutch.

What is the new behavior?

Now the texts are correctly translated.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 9, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Dec 9, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
328.44KB +10%
demo/browser/vendor.(hash).js
204.86KB +10%
demo/browser/runtime.(hash).js
34.39KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change -1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.19MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 61.42% // Head: 61.42% // No change to project coverage 👍

Coverage data is based on head (02e1734) compared to base (0197d56).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3211   +/-   ##
=======================================
  Coverage   61.42%   61.42%           
=======================================
  Files        1515     1515           
  Lines       17920    17920           
  Branches     2509     2509           
=======================================
  Hits        11008    11008           
  Misses       6456     6456           
  Partials      456      456           
Flag Coverage Δ
addon-charts 72.46% <ø> (ø)
addon-doc 48.73% <ø> (ø)
addon-editor 51.23% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 60.71% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.05% <ø> (ø)
core 76.74% <ø> (ø)
kit 73.28% <ø> (ø)
summary 61.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea waterplea merged commit 41cb92e into taiga-family:main Dec 12, 2022
@well-done-bot
Copy link

well-done-bot bot commented Dec 12, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants