Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): share a single subscription to the underlying source observable between multiple subscribers #3174

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Many events are generated every second

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 5, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/refactor/resize-service branch from 4a80a8d to 0847819 Compare December 5, 2022 15:17
@bundlemon
Copy link

bundlemon bot commented Dec 5, 2022

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
328.88KB (+28B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
204.86KB +10%
demo/browser/runtime.(hash).js
34.46KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +28B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.22MB (+28B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Visit the preview URL for this PR (updated for commit 3521f25):

https://taiga-ui--pr3174-splincode-refactor-r-zchqgp1z.web.app

(expires Fri, 16 Dec 2022 07:46:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode force-pushed the splincode/refactor/resize-service branch from 0847819 to 215ee3d Compare December 5, 2022 16:51
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 0.00% // Head: 61.41% // Increases project coverage by +61.41% 🎉

Coverage data is based on head (de83de8) compared to base (2619572).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head de83de8 differs from pull request most recent head 3521f25. Consider uploading reports for the commit 3521f25 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3174       +/-   ##
=========================================
+ Coverage      0   61.41%   +61.41%     
=========================================
  Files         0     1516     +1516     
  Lines         0    17946    +17946     
  Branches      0     2512     +2512     
=========================================
+ Hits          0    11021    +11021     
- Misses        0     6469     +6469     
- Partials      0      456      +456     
Flag Coverage Δ
addon-charts 72.46% <ø> (?)
addon-doc 48.73% <ø> (?)
addon-editor 51.23% <ø> (?)
addon-mobile 62.31% <ø> (?)
addon-table 60.70% <ø> (?)
addon-tablebars 98.07% <ø> (?)
cdk 39.95% <0.00%> (?)
core 76.79% <ø> (?)
kit 73.26% <ø> (?)
summary 61.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/cdk/services/resize.service.ts 60.00% <0.00%> (ø)
...onents/mobile-calendar/mobile-calendar.strategy.ts 82.60% <0.00%> (ø)
...ents/toolbar-tools/font-style/font-style.module.ts 100.00% <0.00%> (ø)
...cts/core/directives/dropdown/dropdown.directive.ts 84.00% <0.00%> (ø)
projects/kit/components/tabs/tabs.directive.ts 19.04% <0.00%> (ø)
projects/addon-charts/utils/line-length.ts 25.00% <0.00%> (ø)
...onents/checkbox-labeled/checkbox-labeled.module.ts 100.00% <0.00%> (ø)
...it/components/input-month/input-month.component.ts 78.78% <0.00%> (ø)
...cdk/directives/repeat-times/repeat-times.module.ts 100.00% <0.00%> (ø)
...ts/kit/components/text-area/text-area.directive.ts 75.00% <0.00%> (ø)
... and 1507 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/refactor/resize-service branch 3 times, most recently from d2ac5ed to 1629f7d Compare December 12, 2022 21:03
@splincode splincode requested a review from waterplea December 12, 2022 21:03
@splincode splincode force-pushed the splincode/refactor/resize-service branch from 1629f7d to ccde555 Compare December 12, 2022 21:05
@splincode splincode closed this Dec 13, 2022
@splincode splincode deleted the splincode/refactor/resize-service branch December 13, 2022 08:24
@splincode splincode restored the splincode/refactor/resize-service branch December 14, 2022 09:45
@splincode splincode reopened this Dec 14, 2022
@splincode splincode force-pushed the splincode/refactor/resize-service branch from ccde555 to 292fd21 Compare December 14, 2022 09:46
@splincode
Copy link
Member Author

@waterplea hello, please review me)

@splincode splincode force-pushed the splincode/refactor/resize-service branch from 292fd21 to ce3c9bc Compare December 14, 2022 12:05
@splincode splincode changed the title refactor(cdk): improve performance for resize service fix(cdk): share a single subscription to the underlying source observable between multiple subscribers Dec 14, 2022
@splincode splincode force-pushed the splincode/refactor/resize-service branch from ce3c9bc to 3521f25 Compare December 15, 2022 07:40
@vladimirpotekhin vladimirpotekhin merged commit 6ee6f50 into main Dec 19, 2022
@vladimirpotekhin vladimirpotekhin deleted the splincode/refactor/resize-service branch December 19, 2022 07:33
@well-done-bot
Copy link

well-done-bot bot commented Dec 19, 2022

'Well done'

splincode added a commit that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants