Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-charts): remove location origin from mask #3125

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3109

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 28, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 61.79% // Head: 61.68% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (205c8b9) compared to base (6d16b12).
Patch coverage: 73.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3125      +/-   ##
==========================================
- Coverage   61.79%   61.68%   -0.12%     
==========================================
  Files        1497     1505       +8     
  Lines       17698    17791      +93     
  Branches     2425     2433       +8     
==========================================
+ Hits        10937    10974      +37     
- Misses       6314     6368      +54     
- Partials      447      449       +2     
Flag Coverage Δ
addon-charts 72.44% <73.33%> (-0.05%) ⬇️
addon-doc 48.40% <ø> (ø)
addon-editor 51.23% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 63.91% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.38% <ø> (+0.01%) ⬆️
core 76.77% <ø> (ø)
kit 73.41% <ø> (-0.54%) ⬇️
summary 61.68% <73.33%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rojects/addon-charts/utils/prepare-external-url.ts 33.33% <33.33%> (ø)
...arts/components/line-chart/line-chart.component.ts 18.75% <60.00%> (+1.00%) ⬆️
...charts/components/pie-chart/pie-chart.component.ts 81.81% <100.00%> (+1.33%) ⬆️
projects/addon-charts/utils/index.ts 100.00% <100.00%> (ø)
projects/cdk/decorators/index.ts 100.00% <0.00%> (ø)
projects/kit/components/index.ts 100.00% <0.00%> (ø)
projects/cdk/utils/miscellaneous/index.ts 100.00% <0.00%> (ø)
projects/kit/components/tiles/tiles.module.ts 100.00% <0.00%> (ø)
projects/kit/components/tiles/tiles.component.ts 22.22% <0.00%> (ø)
...ts/cdk/utils/miscellaneous/array-shallow-equals.ts 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bundlemon
Copy link

bundlemon bot commented Nov 28, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
326.51KB +10%
demo/browser/vendor.(hash).js
205.35KB +10%
demo/browser/runtime.(hash).js
34.33KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.19MB (+73B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

Visit the preview URL for this PR (updated for commit 205c8b9):

https://taiga-ui--pr3125-splincode-fix-issues-cadq8jio.web.app

(expires Tue, 29 Nov 2022 15:48:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@splincode splincode force-pushed the splincode/fix/issues/3109 branch 2 times, most recently from 2a75325 to 617a51d Compare November 28, 2022 10:02
@splincode splincode force-pushed the splincode/fix/issues/3109 branch from 617a51d to 205c8b9 Compare November 28, 2022 15:41
@splincode splincode merged commit eaaa1fa into main Nov 28, 2022
@splincode splincode deleted the splincode/fix/issues/3109 branch November 28, 2022 16:10
@well-done-bot
Copy link

well-done-bot bot commented Nov 28, 2022

'Well done'

oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Dec 1, 2022
oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Dec 1, 2022
oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - PieChart / RingChart mask doesn't work on /next/ demo
3 participants