Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): support capture in input files #3065

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Conversation

splincode
Copy link
Member

@splincode splincode commented Nov 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3063

IMG_6824.MOV

What is the new behavior?

IMG_6825.MOV

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 14, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 14, 2022

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
325.06KB (+649B +0.2%) +10%
demo/browser/runtime.(hash).js
34.24KB (+38B +0.11%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.35KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +687B +0.11%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.19MB (+1.77KB +0.08%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2022

Visit the preview URL for this PR (updated for commit 9a4c834):

https://taiga-ui--pr3065-splincode-feat-issue-dxxeogyt.web.app

(expires Sat, 26 Nov 2022 08:29:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 61.81% // Head: 66.96% // Increases project coverage by +5.14% 🎉

Coverage data is based on head (9a4c834) compared to base (4ba47cd).
Patch coverage: 31.25% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
+ Coverage   61.81%   66.96%   +5.14%     
==========================================
  Files        1495      773     -722     
  Lines       17659     9740    -7919     
  Branches     2416     1377    -1039     
==========================================
- Hits        10916     6522    -4394     
+ Misses       6298     2987    -3311     
+ Partials      445      231     -214     
Flag Coverage Δ
addon-charts 86.77% <ø> (+14.28%) ⬆️
addon-doc 48.40% <ø> (ø)
addon-editor 51.23% <ø> (ø)
addon-mobile 62.31% <ø> (ø)
addon-table 63.91% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk ∅ <ø> (∅)
core ∅ <ø> (∅)
kit 73.94% <31.25%> (-0.22%) ⬇️
summary 66.96% <31.25%> (+5.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...it/components/input-files/input-files.component.ts 17.07% <8.69%> (-0.74%) ⬇️
...it/components/input-files/input-files.directive.ts 31.25% <31.25%> (ø)
.../kit/components/input-files/input-files.options.ts 83.33% <83.33%> (ø)
projects/kit/components/input-files/index.ts 100.00% <100.00%> (ø)
...s/kit/components/input-files/input-files.module.ts 100.00% <100.00%> (ø)
projects/core/tokens/mode.ts
projects/core/internal/index.ts
...ore/components/notification/notification.module.ts
projects/core/components/calendar/index.ts
projects/cdk/classes/validation-error.ts
... and 719 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. We already have 3 attributes that we just pass through to the native file. I wonder if it makes sense to expose native tag instead,

@splincode splincode force-pushed the splincode/feat/issues/3063 branch from e5ef2eb to 41c985a Compare November 15, 2022 11:11
@splincode
Copy link
Member Author

@waterplea We already have 3 attributes that we just pass through to the native file. I wonder if it makes sense to expose native tag instead

we can implement as a feature in separate PR

@splincode splincode requested a review from waterplea November 15, 2022 11:13
@waterplea
Copy link
Collaborator

@waterplea We already have 3 attributes that we just pass through to the native file. I wonder if it makes sense to expose native tag instead

we can implement as a feature in separate PR

Sure. Will you file an issue?

@splincode splincode changed the title feat(kit): support capture in input files [WIP] feat(kit): support capture in input files Nov 15, 2022
@splincode splincode force-pushed the splincode/feat/issues/3063 branch from 41c985a to a6da5ff Compare November 16, 2022 13:59
@splincode splincode changed the title [WIP] feat(kit): support capture in input files feat(kit): support capture in input files Nov 16, 2022
@splincode
Copy link
Member Author

@waterplea fixed

@splincode splincode force-pushed the splincode/feat/issues/3063 branch from a09ac49 to ea22785 Compare November 17, 2022 13:30
@splincode splincode requested a review from waterplea November 17, 2022 13:47
@splincode splincode force-pushed the splincode/feat/issues/3063 branch 2 times, most recently from 618a06c to be03fd7 Compare November 17, 2022 14:47
@splincode splincode force-pushed the splincode/feat/issues/3063 branch 2 times, most recently from ab1fc5f to 0d5a015 Compare November 21, 2022 13:37
@splincode splincode requested a review from waterplea November 21, 2022 16:16
@splincode splincode force-pushed the splincode/feat/issues/3063 branch from 0d5a015 to 1801bdb Compare November 23, 2022 15:31
@splincode splincode force-pushed the splincode/feat/issues/3063 branch from 1801bdb to cc73aad Compare November 23, 2022 16:09
@splincode splincode merged commit 64d212c into main Nov 25, 2022
@splincode splincode deleted the splincode/feat/issues/3063 branch November 25, 2022 13:25
@well-done-bot
Copy link

well-done-bot bot commented Nov 25, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants