-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): support capture in input files #3065
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +687B +0.11% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 9a4c834): https://taiga-ui--pr3065-splincode-feat-issue-dxxeogyt.web.app (expires Sat, 26 Nov 2022 08:29:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov ReportBase: 61.81% // Head: 66.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3065 +/- ##
==========================================
+ Coverage 61.81% 66.96% +5.14%
==========================================
Files 1495 773 -722
Lines 17659 9740 -7919
Branches 2416 1377 -1039
==========================================
- Hits 10916 6522 -4394
+ Misses 6298 2987 -3311
+ Partials 445 231 -214
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. We already have 3 attributes that we just pass through to the native file. I wonder if it makes sense to expose native tag instead,
projects/demo/src/modules/components/input-files/examples/6/index.html
Outdated
Show resolved
Hide resolved
e5ef2eb
to
41c985a
Compare
@waterplea we can implement as a feature in separate PR |
Sure. Will you file an issue? |
41c985a
to
a6da5ff
Compare
@waterplea fixed |
a09ac49
to
ea22785
Compare
618a06c
to
be03fd7
Compare
ab1fc5f
to
0d5a015
Compare
0d5a015
to
1801bdb
Compare
1801bdb
to
cc73aad
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3063
IMG_6824.MOV
What is the new behavior?
IMG_6825.MOV
Does this PR introduce a breaking change?