Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): avatar harness test #3019

Merged

Conversation

zarghamkhandev
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

Partially implements #476

What is the new behavior?

Introduces ComponentHarness for card component.

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 6, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 7, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
323.37KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
34.07KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 68.95% // Head: 61.85% // Decreases project coverage by -7.10% ⚠️

Coverage data is based on head (dd86467) compared to base (a2f0123).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3019      +/-   ##
==========================================
- Coverage   68.95%   61.85%   -7.11%     
==========================================
  Files        1101     1487     +386     
  Lines       13230    17593    +4363     
  Branches     1840     2401     +561     
==========================================
+ Hits         9123    10882    +1759     
- Misses       3798     6273    +2475     
- Partials      309      438     +129     
Flag Coverage Δ
addon-charts 72.48% <ø> (ø)
addon-doc 48.40% <ø> (-0.07%) ⬇️
addon-editor 51.42% <ø> (+0.08%) ⬆️
addon-mobile 62.31% <ø> (ø)
addon-table 64.06% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.26% <ø> (∅)
core 76.79% <ø> (ø)
kit 74.14% <ø> (+0.02%) ⬆️
summary 61.85% <ø> (-7.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/components/navigation/navigation.component.ts 21.42% <0.00%> (-0.26%) ⬇️
projects/addon-editor/extensions/index.ts 100.00% <0.00%> (ø)
...rojects/addon-editor/components/edit-link/index.ts 100.00% <0.00%> (ø)
...on-editor/components/edit-link/edit-link.module.ts 100.00% <0.00%> (ø)
...-update/tests/schematic-migrate-textfields.spec.ts 0.00% <0.00%> (ø)
...ojects/cdk/directives/hovered/hovered.directive.ts 80.00% <0.00%> (ø)
.../schematics/ng-update/steps/replace-deep-import.ts 0.00% <0.00%> (ø)
...dk/schematics/ng-update/steps/migrate-date-time.ts 0.00% <0.00%> (ø)
projects/cdk/observables/watch.ts 100.00% <0.00%> (ø)
...matics/ng-update/tests/schematic-date-time.spec.ts 0.00% <0.00%> (ø)
... and 382 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zarghamkhandev zarghamkhandev force-pushed the testing/avatar-harness-test branch from 3879e8d to 972d12b Compare November 7, 2022 23:15
@zarghamkhandev
Copy link
Contributor Author

@splincode can we get this merged.

@splincode splincode self-requested a review November 12, 2022 17:06
@waterplea waterplea merged commit 970e1d0 into taiga-family:main Nov 15, 2022
@well-done-bot
Copy link

well-done-bot bot commented Nov 15, 2022

'Well done'

splincode pushed a commit that referenced this pull request Nov 15, 2022
oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants