-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): Select
add ability to use native select on mobile
#2964
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
BundleMonFiles updated (2)
Unchanged files (3)
Total files change +831B +0.14% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 26935be): https://taiga-ui--pr2964-native-select-293wq4nn.web.app (expires Tue, 01 Nov 2022 10:03:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
6ab0cfe
to
6a8879e
Compare
Codecov ReportBase: 61.81% // Head: 67.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
==========================================
+ Coverage 61.81% 67.63% +5.82%
==========================================
Files 1472 760 -712
Lines 17387 9543 -7844
Branches 2359 1325 -1034
==========================================
- Hits 10747 6454 -4293
+ Misses 6201 2865 -3336
+ Partials 439 224 -215
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Some comments there.
projects/core/components/primitive-textfield/primitive-textfield.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/select/native-select/native-select.style.less
Outdated
Show resolved
Hide resolved
projects/kit/components/select/native-select/native-select.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/select/native-select/native-select-group.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/select/native-select/native-select-group.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/select/native-select/native-select-group.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/select/native-select/native-select-group.component.ts
Outdated
Show resolved
Hide resolved
a756d01
to
0ad50cd
Compare
Let's enable cleaner for native example. I wonder if it will work properly 🙂 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#1358
What is the new behavior?
2022-10-26.17.45.23.mov
Does this PR introduce a breaking change?