Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): Select add ability to use native select on mobile #2964

Merged
merged 4 commits into from
Oct 31, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

#1358

What is the new behavior?

2022-10-26.17.45.23.mov

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 26, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Oct 26, 2022

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
322.01KB (+794B +0.24%) +10%
demo/browser/runtime.(hash).js
34.07KB (+37B +0.11%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +831B +0.14%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.18MB (+1.85KB +0.08%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

Visit the preview URL for this PR (updated for commit 26935be):

https://taiga-ui--pr2964-native-select-293wq4nn.web.app

(expires Tue, 01 Nov 2022 10:03:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 61.81% // Head: 67.63% // Increases project coverage by +5.82% 🎉

Coverage data is based on head (26935be) compared to base (8ee204b).
Patch coverage: 63.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
+ Coverage   61.81%   67.63%   +5.82%     
==========================================
  Files        1472      760     -712     
  Lines       17387     9543    -7844     
  Branches     2359     1325    -1034     
==========================================
- Hits        10747     6454    -4293     
+ Misses       6201     2865    -3336     
+ Partials      439      224     -215     
Flag Coverage Δ
addon-charts 86.77% <ø> (+14.28%) ⬆️
addon-doc 48.46% <ø> (+0.08%) ⬆️
addon-editor 53.20% <ø> (-0.01%) ⬇️
addon-mobile 62.31% <ø> (+0.62%) ⬆️
addon-table 64.06% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk ∅ <ø> (∅)
core ∅ <ø> (∅)
kit 74.11% <63.63%> (+0.48%) ⬆️
summary 67.63% <63.63%> (+5.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/components/select/native-select/native-select.ts 40.00% <40.00%> (ø)
...ect/native-select/native-select-group.component.ts 57.14% <57.14%> (ø)
...ts/select/native-select/native-select.component.ts 66.66% <66.66%> (ø)
projects/kit/components/select/select.component.ts 75.00% <75.00%> (ø)
projects/kit/components/select/index.ts 100.00% <100.00%> (ø)
projects/kit/components/select/select.module.ts 100.00% <100.00%> (ø)
...onents/color-selector/palette/palette.component.ts 85.71% <0.00%> (-14.29%) ⬇️
...lti-select-option/multi-select-option.component.ts 50.00% <0.00%> (-5.56%) ⬇️
...omponents/documentation/documentation.component.ts 15.68% <0.00%> (-1.30%) ⬇️
...nents/mobile-calendar/mobile-calendar.component.ts 46.03% <0.00%> (-1.08%) ⬇️
... and 740 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Some comments there.

@waterplea
Copy link
Collaborator

Let's enable cleaner for native example. I wonder if it will work properly 🙂

@vladimirpotekhin vladimirpotekhin merged commit c909bec into main Oct 31, 2022
@vladimirpotekhin vladimirpotekhin deleted the native-select branch October 31, 2022 10:43
@well-done-bot
Copy link

well-done-bot bot commented Oct 31, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants