Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-table): Table don't render column with unspecified template #2896

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #2895

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 13, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 3533069):

https://taiga-ui--pr2896-column-unspecified-t-zcoxc568.web.app

(expires Fri, 14 Oct 2022 14:58:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@bundlemon
Copy link

bundlemon bot commented Oct 13, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
317.73KB +10%
demo/browser/vendor.(hash).js
205.38KB +10%
demo/browser/runtime.(hash).js
33.76KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.15MB (+211B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 61.78% // Head: 61.77% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (3533069) compared to base (65d5756).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
- Coverage   61.78%   61.77%   -0.01%     
==========================================
  Files        1465     1465              
  Lines       17335    17339       +4     
  Branches     2353     2353              
==========================================
+ Hits        10710    10711       +1     
- Misses       6186     6189       +3     
  Partials      439      439              
Flag Coverage Δ
addon-charts 72.48% <ø> (ø)
addon-doc 48.38% <ø> (ø)
addon-editor 53.20% <ø> (ø)
addon-mobile 61.68% <ø> (ø)
addon-table 64.06% <33.33%> (-0.38%) ⬇️
addon-tablebars 98.07% <ø> (ø)
cdk 40.30% <ø> (ø)
core 76.25% <ø> (ø)
kit 73.63% <ø> (ø)
summary 61.77% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/addon-table/components/table/tr/tr.component.ts 41.66% <33.33%> (-3.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nsbarsukov nsbarsukov merged commit 526c40a into main Oct 14, 2022
@nsbarsukov nsbarsukov deleted the column-unspecified-template-bug branch October 14, 2022 08:40
@well-done-bot
Copy link

well-done-bot bot commented Oct 14, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Table don't render column with unspecified template
3 participants