Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): Badge add overflow elipsis and title #2806

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

2022-10-05.13.16.16.mov

Closes #

What is the new behavior?

2022-10-05.13.04.49.mov

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 5, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Visit the preview URL for this PR (updated for commit 8f30e28):

https://taiga-ui--pr2806-badge-text-ur63n4h0.web.app

(expires Thu, 06 Oct 2022 10:33:27 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 39.97% // Head: 39.94% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (8f30e28) compared to base (eb5bf82).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
- Coverage   39.97%   39.94%   -0.04%     
==========================================
  Files         957      958       +1     
  Lines        9240     9248       +8     
  Branches     1895     1901       +6     
==========================================
  Hits         3694     3694              
- Misses       5342     5350       +8     
  Partials      204      204              
Flag Coverage Δ
addon-charts 73.77% <ø> (ø)
addon-doc 18.72% <ø> (ø)
addon-editor 28.64% <ø> (-0.19%) ⬇️
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 62.87% <ø> (ø)
core 60.90% <ø> (ø)
kit 19.18% <0.00%> (-0.01%) ⬇️
summary 39.94% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/kit/components/badge/badge.component.ts 33.33% <0.00%> (-2.39%) ⬇️
projects/kit/components/badge/badge.module.ts 100.00% <ø> (ø)
...addon-editor/components/editor/editor.component.ts 9.09% <0.00%> (-1.26%) ⬇️
projects/addon-editor/utils/safe-link-range.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@waterplea waterplea merged commit 02713d6 into main Oct 5, 2022
@waterplea waterplea deleted the badge-text branch October 5, 2022 15:25
@well-done-bot
Copy link

well-done-bot bot commented Oct 5, 2022

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants