Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit)!: Slider | InputSlider | Range | InputRange use strict version of TuiKeySteps #2220

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

export type TuiKeySteps = Array<[number, number]>;

What is the new behavior?

export type TuiKeySteps = [[0, number], ...Array<[number, number]>, [100, number]];

Does this PR introduce a breaking change?

  • Yes
  • No

@nsbarsukov nsbarsukov self-assigned this Jul 27, 2022
@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 27, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Visit the preview URL for this PR (updated for commit 5172abf):

https://taiga-ui--pr2220-key-steps-strict-typ-yrju0x74.web.app

(expires Thu, 28 Jul 2022 15:55:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2220 (5172abf) into v3.x (ee8b2cf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             v3.x    #2220      +/-   ##
==========================================
- Coverage   56.99%   56.98%   -0.02%     
==========================================
  Files         962      962              
  Lines        9818     9815       -3     
  Branches     1968     1966       -2     
==========================================
- Hits         5596     5593       -3     
  Misses       3789     3789              
  Partials      433      433              
Flag Coverage Δ
addon-charts 74.02% <ø> (ø)
addon-doc 20.47% <ø> (ø)
addon-editor 31.56% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 65.37% <ø> (ø)
core 66.50% <ø> (ø)
kit 57.65% <100.00%> (-0.04%) ⬇️
summary 56.98% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/slider/helpers/slider-key-steps.directive.ts 76.19% <ø> (-1.09%) ⬇️
projects/kit/utils/math/key-steps.ts 100.00% <ø> (ø)
.../components/input-slider/input-slider.component.ts 75.51% <100.00%> (+0.51%) ⬆️
projects/kit/components/range/range.component.ts 83.92% <100.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee8b2cf...5172abf. Read the comment docs.

@nsbarsukov nsbarsukov force-pushed the key-steps-strict-typings branch from 8e0dcbc to f359f67 Compare July 27, 2022 15:47
@nsbarsukov nsbarsukov changed the title [WIP] feat(kit)!: Slider | InputSlider | Range | InputRange use strict version of TuiKeySteps feat(kit)!: Slider | InputSlider | Range | InputRange use strict version of TuiKeySteps Jul 27, 2022
@nsbarsukov nsbarsukov marked this pull request as ready for review July 27, 2022 15:47
@nsbarsukov nsbarsukov merged commit b0d2a4a into v3.x Jul 28, 2022
@nsbarsukov nsbarsukov deleted the key-steps-strict-typings branch July 28, 2022 07:08
@well-done-bot
Copy link

well-done-bot bot commented Jul 28, 2022

'Well done'

splincode pushed a commit that referenced this pull request Jul 28, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Jul 29, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 1, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 1, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 1, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 1, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 1, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 1, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 1, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 3, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 4, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 4, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 5, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 6, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 8, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 8, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 8, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 8, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 9, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 9, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 10, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 16, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 16, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 22, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 23, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 23, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 23, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 23, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 24, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
tinkoff-bot added a commit that referenced this pull request Aug 24, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 25, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 25, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 26, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
splincode pushed a commit that referenced this pull request Aug 30, 2022
…ict version of `TuiKeySteps` (#2220)

* feat(kit)!: `Slider` | `InputSlider` | `Range` | `InputRange` use strict version of `TuiKeySteps`

* chore: apply changes after linting [tinkoff-bot]

Co-authored-by: tinkoff-bot <[email protected]>
This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants