Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove date-time related deprecations, EMPTY_VALIDATOR #2164

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

vladimirpotekhin
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 20, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022

Visit the preview URL for this PR (updated for commit 4401445):

https://taiga-ui--pr2164-cdk-deprecated-1rkazw63.web.app

(expires Sat, 23 Jul 2022 07:06:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #2164 (4401445) into v3.x (d15c8d2) will decrease coverage by 0.15%.
The diff coverage is 62.96%.

@@            Coverage Diff             @@
##             v3.x    #2164      +/-   ##
==========================================
- Coverage   60.72%   60.57%   -0.16%     
==========================================
  Files         917      917              
  Lines        9398     9351      -47     
  Branches     1888     1885       -3     
==========================================
- Hits         5707     5664      -43     
+ Misses       3257     3254       -3     
+ Partials      434      433       -1     
Flag Coverage Δ
addon-charts 74.40% <ø> (-0.05%) ⬇️
addon-doc 21.23% <ø> (ø)
addon-editor 46.19% <0.00%> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 83.78% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 65.87% <85.71%> (-0.73%) ⬇️
core 67.20% <55.55%> (ø)
kit 59.33% <0.00%> (ø)
summary 60.57% <62.96%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
projects/addon-commerce/enums/currency-code.ts 100.00% <ø> (ø)
...or/directives/design-mode/design-mode.directive.ts 22.30% <0.00%> (ø)
projects/cdk/constants/empty.ts 100.00% <ø> (ø)
projects/cdk/date-time/date-fillers.ts 100.00% <ø> (ø)
projects/cdk/date-time/month-range.ts 100.00% <ø> (ø)
projects/cdk/date-time/time.ts 97.95% <ø> (ø)
.../cdk/directives/focus-trap/focus-trap.directive.ts 5.88% <0.00%> (ø)
projects/cdk/exceptions/invalid-day.exception.ts 100.00% <ø> (ø)
projects/cdk/exceptions/invalid-month.exception.ts 100.00% <ø> (ø)
projects/cdk/exceptions/invalid-year.exception.ts 100.00% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15c8d2...4401445. Read the comment docs.

@vladimirpotekhin vladimirpotekhin merged commit f6cf3b8 into v3.x Jul 22, 2022
@vladimirpotekhin vladimirpotekhin deleted the cdk-deprecated branch July 22, 2022 07:21
@well-done-bot
Copy link

well-done-bot bot commented Jul 22, 2022

'Well done'

This was referenced Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants