Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 - No visual feedback when pressing a button on mobile device #1034

Closed
2 of 9 tasks
VictorienTardif opened this issue Nov 23, 2021 · 6 comments · Fixed by #1074
Closed
2 of 9 tasks

🚀 - No visual feedback when pressing a button on mobile device #1034

VictorienTardif opened this issue Nov 23, 2021 · 6 comments · Fixed by #1074
Assignees
Labels
P3 This issue has low priority

Comments

@VictorienTardif
Copy link
Contributor

Which @taiga-ui/* package(s) are the source of the bug?

core

Please provide a link to a minimal reproduction of the bug

https://taiga-ui.dev/components/button

Description

When touching a button on mobile (on mine at least, Android 10), there's no feedback.
You can test it by opening the buttons examples: https://taiga-ui.dev/components/button
It looks like a _pressed class should be added if I read the code correctly but something is not working.

Angular version

12.2.4

Taiga UI version

2.24.0

Which browsers have you used?

  • Chrome
  • Firefox
  • Safari
  • Edge

Which operating systems have you used?

  • macOS
  • Windows
  • Linux
  • iOS
  • Android
@VictorienTardif
Copy link
Contributor Author

Hello, could you take a look at this issue or tell me if I'm missing something?

I find it very confusing to have no feedback at all when touching a button a mobile and I can't believe it's the case in your interfaces is it?

@waterplea
Copy link
Collaborator

Yeah, that's because mousedown and mouseup are triggered instantaneously upon finger release on touch devices. We have a bigger feature to cover this:
#928
I have made a small fix for buttons until this feature is implemented:
#1074

@VictorienTardif
Copy link
Contributor Author

Ok nice thank you!!

@VictorienTardif
Copy link
Contributor Author

Hello @waterplea, I just realized that for some reason it was still not working with appearance='flat' and tuiMode. While we do have a change of background color on web, we don't have it on mobile.

See https://taiga-ui.dev/components/button/API?tuiMode=onDark&icon=tuiIconEyeClosed&appearance=flat

@waterplea
Copy link
Collaborator

waterplea commented Jan 11, 2022

Yes, looks like the fix only covered "modeless" appearance. I'll reopen this issue and fix it for mode too.

@waterplea waterplea reopened this Jan 11, 2022
@waterplea waterplea added the P3 This issue has low priority label Jan 20, 2022
@waterplea
Copy link
Collaborator

Fixed in 3.0

@github-project-automation github-project-automation bot moved this to 💡 Backlog in Taiga-family Sep 25, 2023
@splincode splincode moved this from 💡 Backlog to ✅ Done in Taiga-family Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 This issue has low priority
Development

Successfully merging a pull request may close this issue.

2 participants