feat: add server logout handler #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch; I kinda rushed the auth part as I don't really need it for my current use-cases. Would love having a review from you on that side. Also, I guess we could go 1 step further and also include exports to simplify communication with OAuth providers APIs. Currently, we don't preserve anything from these providers, like the email of a user from GitHub or Google. WDYT? |
|
Hey, thanks for merging. I haven't looked at the OAuth stuff at all by now, so I can't give a qualified opinion. I'm totally new to EdgeDB and haven't used it before. As I'm growing more familiar with it over the coming weeks, I will come back with more input and the occasional PR. I think you did a great job with the module so far and I'm looking forward to helping shape it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds server action to properly terminate session by expiring the auth token cookie. Fixes #4.