Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

endianness for sequential/rijndael_xxx #8

Open
ghost opened this issue Apr 24, 2018 · 2 comments
Open

endianness for sequential/rijndael_xxx #8

ghost opened this issue Apr 24, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 24, 2018

The code for sequential/rijndael_enc and sequential/rijndael_dec appears to be sensitive to the platform's endianness. The AES source code from MiBench, for instance, contains explicit conversions to handle this.

Simple Solution:
A simple solution would be to introduce defines that control endianess (which would be needed for other benchmarks anyways -- more issue requests are on the way). This would allow at least to compare against checksums depending on the platform's endianness.

@ghost
Copy link
Author

ghost commented Apr 24, 2018

Btw., the same applies also to sequential/adpcm_enc.

@schoeberl
Copy link
Member

Yes, this is known that there are some endianess dependencies in the benchmarks. I consider this bad C code and argued for removing those benchmarks. And I still am ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant